Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples should have an option to pull AMD64 or ARM64 / default to host #1154

Closed
cdrage opened this issue Jan 6, 2025 · 2 comments · Fixed by #1196
Closed

Examples should have an option to pull AMD64 or ARM64 / default to host #1154

cdrage opened this issue Jan 6, 2025 · 2 comments · Fixed by #1196
Assignees
@cdrage
Labels
kind/enhancement ✨ Issue for requesting an improvement
Milestone
1.7

Comments

@cdrage
Copy link
Contributor

cdrage commented Jan 6, 2025

Is your enhancement related to a problem? Please describe

When pulling or using the examples, we should be able to select if we want to pull either AMD64 or ARM64.

This is because if you are running the examples on mac m1, it is much faster using the arm examples, and vice versa for amd64 architecture.

We can now pull as per architecture in the Podman Desktop API, so this is now possible within bootc.

Describe the solution you'd like

Be able to select pulling amd64 or arm64 examples.

Describe alternatives you've considered

No response

Additional context

No response
@cdrage cdrage added the kind/enhancement ✨ Issue for requesting an improvement label Jan 6, 2025
@cdrage cdrage self-assigned this Jan 6, 2025
@cdrage cdrage moved this to 📋 Backlog in Podman Desktop Planning OLD Jan 6, 2025
@cdrage cdrage added this to the 1.7 milestone Jan 13, 2025
@vrothberg
Copy link
Contributor

Shouldn't we default to always pull the native platform? One thing less to worry about as a user and less things to maintain.

@cdrage
Copy link
Contributor Author

cdrage commented Jan 13, 2025

Shouldn't we default to always pull the native platform? One thing less to worry about as a user and less things to maintain.

Yup! Should default to host system architecture first but also have option to pull other arch's (for ex. building amd64 images on mac)

@cdrage cdrage moved this from 📋 Backlog to 🚧 In Progress in Podman Desktop Planning OLD Jan 14, 2025
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Jan 16, 2025
@cdrage
feat: Adds option to pull arm64/amd64 examples
442c1bc 
### What does this PR do?

* Adds the ability to choose what initial arm64 or amd64 image example
  you want
* Defaults to native architecture when initially loading
* Pulls the architecture correctly

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#1154

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Go to examples page
2. Select from the drop down the arch you want
3. Pull the image & build
@cdrage cdrage mentioned this issue Jan 16, 2025
Merged
@cdrage cdrage moved this from 🚧 In Progress to 🚥 In Review in Podman Desktop Planning OLD Jan 16, 2025
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Jan 16, 2025
@cdrage
feat: Adds option to pull arm64/amd64 examples
7869519 
### What does this PR do?

* Adds the ability to choose what initial arm64 or amd64 image example
  you want
* Defaults to native architecture when initially loading
* Pulls the architecture correctly

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#1154

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Go to examples page
2. Select from the drop down the arch you want
3. Pull the image & build

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Jan 16, 2025
@cdrage
feat: Adds option to pull arm64/amd64 examples
5c9bb3f 
### What does this PR do?

* Adds the ability to choose what initial arm64 or amd64 image example
  you want
* Defaults to native architecture when initially loading
* Pulls the architecture correctly

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#1154

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Go to examples page
2. Select from the drop down the arch you want
3. Pull the image & build

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Jan 22, 2025
@cdrage
feat: Adds option to pull arm64/amd64 examples
f90bec7 
### What does this PR do?

* Adds the ability to choose what initial arm64 or amd64 image example
  you want
* Defaults to native architecture when initially loading
* Pulls the architecture correctly

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#1154

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Go to examples page
2. Select from the drop down the arch you want
3. Pull the image & build

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit that referenced this issue Jan 23, 2025
@cdrage
feat: Adds option to pull arm64/amd64 examples (#1196)
750470b 
* feat: Adds option to pull arm64/amd64 examples

### What does this PR do?

* Adds the ability to choose what initial arm64 or amd64 image example
  you want
* Defaults to native architecture when initially loading
* Pulls the architecture correctly

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes #1154

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Go to examples page
2. Select from the drop down the arch you want
3. Pull the image & build

Signed-off-by: Charlie Drage <[email protected]>

* chore: update based on review

Signed-off-by: Charlie Drage <[email protected]>

* chore: update to use getArch

Signed-off-by: Charlie Drage <[email protected]>

---------

Signed-off-by: Charlie Drage <[email protected]>
@github-project-automation github-project-automation bot moved this from 🚥 In Review to ✔️ Done in Podman Desktop Planning OLD Jan 23, 2025
@nichjones1 nichjones1 moved this to ✔️ Done in Podman Desktop Planning Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
kind/enhancement ✨ Issue for requesting an improvement
Projects
Podman Desktop Planning
Status: ✔️ Done
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

feat: Adds option to pull arm64/amd64 examples cdrage/podman-desktop-extension-bootc
2 participants
@cdrage @vrothberg