Icons not displayed in FilePicker when using german language

[geoo]

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.20.0]

Expected / Desired Behavior / Question

Icons are displayed when using the FilePicker component

Observed Behavior

When using the compact or list view of the FilePicker component the icons are not displayed if using german language (and a lot other languages)

The "FolderIconUrl" in https://github.com/pnp/sp-dev-fx-controls-react/blob/master/src/loc/de-de.ts is pointing to a non existing svg ("https://spoprod-a.akamaihd.net/files/odsp-next-prod_2019-01-11_20190116.001/odsp-media/images/itemtypes/20/folder.svg")

Thanks!

[github-actions]

Thank you for submitting your first issue to this project.

[Ateina]

Hi @michaelmaillot @joelfmrodrigues!

So, I suppose, correct link for FolderIconUrl would be folder icon link

After a quick investigation, I noticed several other icons referencing non-existent paths, but they are wrong for all languages:

• OneDriveEmptyFolderIconUrl, maybe could be replaced with Font Icon

• ODPhotoIconUrl, possible replacement photo icon link
• PhotoIconUrl - only used in a commented block of code, maybe could be removed completely

[michaelmaillot]

Hi @geoo & @Ateina, thanks for raising this and the investigation!

Looks like "system" icons are refered to ODSP CDN, which location evolves with released versions and I'm not sure this should be handled like this in a long term perspective.

@AJIXuMuK do you know if there's a better way to get those generic icons, instead of using Akamai URLs?