Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove viva engage group commands #6285

Open
milanholemans opened this issue Aug 29, 2024 · 2 comments
Open

Remove viva engage group commands #6285

milanholemans opened this issue Aug 29, 2024 · 2 comments

Comments

@milanholemans
Copy link
Contributor

milanholemans commented Aug 29, 2024

Since we now have the following specs:

We could get rid of commands:

  • viva engage group list
  • viva engage group user add
  • viva engage group user remove

This would mean that we need a spec for the last two commands mentioned above as well.

Why should we remove these commands? Viva Engage groups and communities are the same thing. The group APIs use an unstable undocumented API that required extra scopes to be consented on the app registration. While the community commands just use Graph.

If we agree, we can spec out viva engage community user add and viva engage community user remove.


On hold until these are implemented:

@milanholemans milanholemans added breaking change needs peer review Needs second pair of eyes to review the spec or PR labels Aug 29, 2024
@milanholemans milanholemans added this to the v9 milestone Aug 29, 2024
@Jwaegebaert
Copy link
Contributor

Sounds good. Let's put this on hold until the commands are created and track our progress here. I'll start working on speccing them out.

@Jwaegebaert Jwaegebaert added on hold and removed needs peer review Needs second pair of eyes to review the spec or PR labels Sep 2, 2024
@Adam-it Adam-it modified the milestones: v10, v11 Oct 30, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 30, 2024

we agreed to move it to v11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants