Skip to content

Commit af238be

Browse files
committed
Fix #1
Also switch from numbered list to headings.
1 parent d171d97 commit af238be

File tree

1 file changed

+24
-4
lines changed

1 file changed

+24
-4
lines changed

rust/arith-overflow-buglist.md

+24-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ included in the list.
1515
However, extremely rare or obscure corner cases are considered
1616
legitimate bugs. (We begin with such a case.)
1717

18-
1. `impl core::iter::RandomAccessIter for core::iter::Rev`
18+
### `impl core::iter::RandomAccessIter for core::iter::Rev`
1919

2020
if one calls the `iter.idx(index)` with `index <= amt`,
2121
then it calls the wrapped inner iterstor with a wrapped
@@ -29,7 +29,7 @@ legitimate bugs. (We begin with such a case.)
2929
reference:
3030
https://github.com/rust-lang/rust/pull/22532#issuecomment-75168901
3131

32-
2. `std::sys::windows::time::SteadyTime`
32+
### `std::sys::windows::time::SteadyTime`
3333

3434
`fn ns` was converting a tick count `t` to nanoseconds
3535
via the computation `t * 1_000_000_000 / frequency()`;
@@ -51,7 +51,8 @@ legitimate bugs. (We begin with such a case.)
5151
overflow forces such bugs to be fixed in some manner
5252
rather than ignored.
5353

54-
3. `std::rt::lang_start`
54+
### `std::rt::lang_start`
55+
5556
The runtime startup uses a fairly loose computation to
5657
determine the stack extent to pass to
5758
record_os_managed_stack_bounds (which sets up guard
@@ -104,7 +105,7 @@ legitimate bugs. (We begin with such a case.)
104105
saturated arithmetic in both cases, though obviously
105106
that could be tweaked a bit.)
106107

107-
4. struct order of evaluation
108+
### struct order of evaluation
108109

109110
There is an explanatory story here:
110111

@@ -124,3 +125,22 @@ legitimate bugs. (We begin with such a case.)
124125
but it probably would have been much harder to diagnose
125126
since the panic would have happened at some arbitrary
126127
point later in the control flow.
128+
129+
### Invalid `Span` constructions:
130+
131+
https://github.com/rust-lang/rust/issues/23480
132+
133+
Experts in the syntax system probably already knew
134+
about this bug, but overflow checking forced everyone
135+
to be reminded of it, repeatedly, in:
136+
137+
https://github.com/rust-lang/rust/issues/23115
138+
139+
See in particular:
140+
141+
https://github.com/rust-lang/rust/issues/23115#issuecomment-82960834
142+
143+
We have not actually *fixed* issue #23480 at the time of
144+
this writing. Instead we put in a workaround:
145+
146+
https://github.com/rust-lang/rust/pull/23489

0 commit comments

Comments
 (0)