Skip to content

fix: align SDK parity type gaps#958

Open
realfishsam wants to merge 1 commit into
mainfrom
fix/easy-sdk-parity-python-types-2
Open

fix: align SDK parity type gaps#958
realfishsam wants to merge 1 commit into
mainfrom
fix/easy-sdk-parity-python-types-2

Conversation

@realfishsam

@realfishsam realfishsam commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Python fetch_trades resolution forwarding and SubscriptionOption typing
  • tighten Python BuiltOrder/cluster model typings and FeedClient errors
  • add TypeScript hosted-mode submitOrder guard through the client method generator
  • add TypeScript Router query/category params

Fixes #654
Fixes #651
Fixes #650
Fixes #649
Fixes #501
Fixes #500
Fixes #467
Fixes #178
Fixes #176
Fixes #175

Test Plan

  • python3 -m py_compile sdks/python/pmxt/models.py sdks/python/pmxt/client.py sdks/python/pmxt/feed_client.py sdks/python/pmxt/init.py
  • node sdks/typescript/scripts/generate-client-methods.js && git diff --exit-code sdks/typescript/pmxt/client.ts
  • git diff --check
  • npm run build --workspace=pmxt-core (fails locally: process killed in this worktree)
  • npx tsc --noEmit -p sdks/typescript/tsconfig.json (fails locally: generated TypeScript client missing from checkout)

@realfishsam realfishsam force-pushed the fix/easy-sdk-parity-python-types-2 branch from a43c72b to ca88943 Compare June 8, 2026 11:05
@realfishsam

Copy link
Copy Markdown
Contributor Author

PR Review: PASS (NOT VERIFIED)

What This Does

Closes SDK type parity gaps around create-order params, feed errors, subscription options, volume fields, and router query/category parameters.

Blast Radius

Python SDK client/feed/models and TypeScript client/router/generator script.

Consumer Verification

Before (base branch):
Base SDK consumers lacked several type aliases/options and hosted submitOrder did not have the explicit local-only guard added here.

After (PR branch):
PR adds those SDK type/guard changes. Core build/Jest passed (24 suites, 644 tests); root verification then failed only because Python pytest is missing.

Test Results

  • Build: PASS
  • Unit tests: CORE PASS (24 suites, 644 tests; root verification blocked by missing pytest)
  • Server starts: PASS during root verification
  • E2E smoke: NOT VERIFIED (SDK runtime/import smoke not run)

Findings

No blocking findings.

PMXT Pipeline Check

  • Field propagation (3-layer): N/A
  • OpenAPI sync: N/A
  • Financial precision: N/A
  • Type safety: OK
  • Auth safety: N/A

Semver Impact

patch -- SDK type/guard parity fix.

Risk

Type-level consumer import behavior was not executed because the SDK test environment is incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment