Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL's getting changed mid-flight #2

Open
guzmanbraso opened this issue Feb 7, 2020 · 3 comments
Open

URL's getting changed mid-flight #2

guzmanbraso opened this issue Feb 7, 2020 · 3 comments

Comments

@guzmanbraso
Copy link

Hi Pedro,

First, THANK YOU. Your extension saved hours of frustration thanks to Atlassian not so friendly approach to user management between products, so thanks to you I can automatically use bitbucket in incognito and jira in the common one.

Now the issue, it seems you convert the url to lowercase to test it in a case insensitive way against whitelist/blacklist/whatever, but at the end of the process the url that should be sent to the browser is the original one and not the one converted to lowercase. URL's are case sensitive and for example a file CHANGELOG.md in a github repo would get open as changelog.md which won't work.

I'm sorry I can't help you now with a patch, I've a shitload of work to do right now but in case this keeps open a few weeks I'll take care of it.

Thank you again,

Guzman

@jeyrella
Copy link

jeyrella commented Jun 29, 2020

Would like to see this fixed too, any progress? @pmsosa

@pmsosa
Copy link
Owner

pmsosa commented Aug 6, 2020

Fixed in repo (commit: d88eabb) . Won't close this until I repack and re-upload to the chrome Store.

@prot475
Copy link

prot475 commented Jan 12, 2021

+1 on the Thanks for the great extension!

Also looking forward to this fix. I'm running into the same issue where all case-sensitive URLs return an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants