Skip to content

Commit 4675c0a

Browse files
committed
Comment out BigIntReading.smithy4sJson benchmark
1 parent 5aad46b commit 4675c0a

File tree

8 files changed

+24
-12
lines changed

8 files changed

+24
-12
lines changed

jsoniter-scala-benchmark/js/src/main/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/Main.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,8 @@ object Main {
952952
//FIXME: circe-jsoniter parses up to 308 digits only
953953
//B("circeJsoniter")(benchmark.circeJsoniter()),
954954
B("jsoniterScala")(benchmark.jsoniterScala()),
955-
B("smithy4sJson")(benchmark.smithy4sJson()),
955+
// FIXME: smithy4sJson parses up to 308 digits only
956+
//B("smithy4sJson")(benchmark.smithy4sJson()),
956957
B("uPickle")(benchmark.uPickle()),
957958
B("zioJson")(benchmark.zioJson())
958959
))

jsoniter-scala-benchmark/js/src/main/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/Main.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -885,7 +885,8 @@ object Main {
885885
//FIXME: circe-jsoniter parses up to 308 digits only
886886
//B("circeJsoniter")(benchmark.circeJsoniter()),
887887
B("jsoniterScala")(benchmark.jsoniterScala()),
888-
B("smithy4sJson")(benchmark.smithy4sJson()),
888+
// FIXME: smithy4sJson parses up to 308 digits only
889+
//B("smithy4sJson")(benchmark.smithy4sJson()),
889890
B("uPickle")(benchmark.uPickle()),
890891
B("zioJson")(benchmark.zioJson())
891892
))

jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigIntReadingSpec.scala

+4-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
1818
benchmark.jsoniterScala() shouldBe benchmark.obj
1919
//FIXME: Play-JSON looses significant digits in BigInt values
2020
//benchmark.playJson() shouldBe benchmark.obj
21-
benchmark.smithy4sJson() shouldBe benchmark.obj
21+
// FIXME: smithy4sJson parses up to 308 digits only
22+
//benchmark.smithy4sJson() shouldBe benchmark.obj
2223
benchmark.uPickle() shouldBe benchmark.obj
2324
benchmark.zioJson() shouldBe benchmark.obj
2425
}
@@ -32,7 +33,8 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
3233
//FIXME: circe-jsoniter parses up to 308 digits only
3334
//intercept[Throwable](b.circeJsoniter())
3435
intercept[Throwable](b.jsoniterScala())
35-
intercept[Throwable](b.smithy4sJson())
36+
// FIXME: smithy4sJson parses up to 308 digits only
37+
//intercept[Throwable](b.smithy4sJson())
3638
intercept[Throwable](b.uPickle())
3739
intercept[Throwable](b.zioJson())
3840
}

jsoniter-scala-benchmark/js/src/test/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigIntReadingSpec.scala

+4-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
1717
benchmark.jsoniterScala() shouldBe benchmark.obj
1818
//FIXME: Play-JSON looses significant digits in BigInt values
1919
//benchmark.playJson() shouldBe benchmark.obj
20-
benchmark.smithy4sJson() shouldBe benchmark.obj
20+
// FIXME: smithy4sJson parses up to 308 digits only
21+
//benchmark.smithy4sJson() shouldBe benchmark.obj
2122
benchmark.uPickle() shouldBe benchmark.obj
2223
benchmark.zioJson() shouldBe benchmark.obj
2324
}
@@ -30,7 +31,8 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
3031
//FIXME: circe-jsoniter parses up to 308 digits only
3132
//intercept[Throwable](b.circeJsoniter())
3233
intercept[Throwable](b.jsoniterScala())
33-
intercept[Throwable](b.smithy4sJson())
34+
//FIXME: smithy4sJson parses up to 308 digits only
35+
//intercept[Throwable](b.smithy4sJson())
3436
intercept[Throwable](b.uPickle())
3537
intercept[Throwable](b.zioJson())
3638
}

jsoniter-scala-benchmark/jvm/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigIntReadingSpec.scala

+4-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
2323
benchmark.jsoniterScala() shouldBe benchmark.obj
2424
//FIXME: Play-JSON looses significant digits in BigInt values
2525
//benchmark.playJson() shouldBe benchmark.obj
26-
benchmark.smithy4sJson() shouldBe benchmark.obj
26+
// FIXME: smithy4sJson parses up to 308 digits only
27+
//benchmark.smithy4sJson() shouldBe benchmark.obj
2728
benchmark.sprayJson() shouldBe benchmark.obj
2829
benchmark.uPickle() shouldBe benchmark.obj
2930
benchmark.weePickle() shouldBe benchmark.obj
@@ -44,7 +45,8 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
4445
//FIXME: json4s.native throws org.json4s.ParserUtil$ParseException: expected field or array
4546
//intercept[Throwable](b.json4sNative())
4647
intercept[Throwable](b.jsoniterScala())
47-
intercept[Throwable](b.smithy4sJson())
48+
// FIXME: smithy4sJson parses up to 308 digits only
49+
//intercept[Throwable](b.smithy4sJson())
4850
intercept[Throwable](b.sprayJson())
4951
intercept[Throwable](b.uPickle())
5052
intercept[Throwable](b.weePickle())

jsoniter-scala-benchmark/jvm/src/test/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigIntReadingSpec.scala

+4-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
2121
benchmark.jsoniterScala() shouldBe benchmark.obj
2222
//FIXME: Play-JSON looses significant digits in BigInt values
2323
//benchmark.playJson() shouldBe benchmark.obj
24-
benchmark.smithy4sJson() shouldBe benchmark.obj
24+
// FIXME: smithy4sJson parses up to 308 digits only
25+
//benchmark.smithy4sJson() shouldBe benchmark.obj
2526
benchmark.sprayJson() shouldBe benchmark.obj
2627
benchmark.uPickle() shouldBe benchmark.obj
2728
benchmark.weePickle() shouldBe benchmark.obj
@@ -40,7 +41,8 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
4041
//FIXME: json4s.native throws org.json4s.ParserUtil$ParseException: expected field or array
4142
//intercept[Throwable](b.json4sNative())
4243
intercept[Throwable](b.jsoniterScala())
43-
intercept[Throwable](b.smithy4sJson())
44+
// FIXME: smithy4sJson parses up to 308 digits only
45+
//intercept[Throwable](b.smithy4sJson())
4446
intercept[Throwable](b.sprayJson())
4547
intercept[Throwable](b.uPickle())
4648
intercept[Throwable](b.weePickle())

jsoniter-scala-benchmark/shared/src/main/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigIntReading.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,15 @@ class BigIntReading extends BigIntBenchmark {
8484
Json.parse(jsonBytes).as[BigInt]
8585
}
8686
*/
87+
/* FIXME: smithy4sJson parses up to 308 digits only
8788
@Benchmark
8889
def smithy4sJson(): BigInt = {
8990
import com.github.plokhotnyuk.jsoniter_scala.benchmark.Smithy4sJCodecs._
9091
import com.github.plokhotnyuk.jsoniter_scala.core._
9192
9293
readFromArray[BigInt](jsonBytes)(bigIntJCodec)
9394
}
94-
95+
*/
9596
@Benchmark
9697
def sprayJson(): BigInt = {
9798
import com.github.plokhotnyuk.jsoniter_scala.benchmark.SprayFormats._

jsoniter-scala-benchmark/shared/src/main/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigIntReading.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,15 @@ class BigIntReading extends BigIntBenchmark {
7272
Json.parse(jsonBytes).as[BigInt]
7373
}
7474
*/
75+
/* FIXME: smithy4sJson parses up to 308 digits only
7576
@Benchmark
7677
def smithy4sJson(): BigInt = {
7778
import com.github.plokhotnyuk.jsoniter_scala.benchmark.Smithy4sJCodecs._
7879
import com.github.plokhotnyuk.jsoniter_scala.core._
7980
8081
readFromArray[BigInt](jsonBytes)(bigIntJCodec)
8182
}
82-
83+
*/
8384
@Benchmark
8485
def sprayJson(): BigInt = {
8586
import com.github.plokhotnyuk.jsoniter_scala.benchmark.SprayFormats._

0 commit comments

Comments
 (0)