Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to resume a session #4

Open
mikesir87 opened this issue Jun 1, 2017 · 2 comments
Open

Ability to resume a session #4

mikesir87 opened this issue Jun 1, 2017 · 2 comments

Comments

@mikesir87
Copy link

Currently, the SDK only provides the ability to create a new session. But, if the client already has a session identifier (maybe stored in LocalStorage), it would be nice to have the ability to resume that session, preventing the need to create new containers.

In Slack, we talked about creating a pwd.resumeSession method that requires a session identifier to resume. May need to think about if there are any other config changes.

@marcosnils
Copy link
Contributor

marcosnils commented Mar 25, 2018

@mikesir87 @roicostas this is currently possible using the current init function in the SDK. That's how the ee-workhops work (https://github.com/play-with-docker/ee-workshop/blob/master/app/scripts/services/pwd.js#L25-L32) as you can refresh the page and you'll get the same session as before as the session_id is stored in the URL. Is there something else that you see it's missing?

@roicostas
Copy link

The init function allows you to open a previous session based on the session_id however it does not restore the instance terminals. The resumeSession function uses the init function to restore the session and then recreates the previous terminals. This way you can continue with your previous containers, images etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants