Simplify per-thread PHP init - ThreadScope only, remove Sapi::startup()

The previous approach of calling php_module_startup() per-request caused
assertion failures in zend_new_interned_string_permanent when called
concurrently from multiple threads.

PHP's architecture uses:
- php_module_startup() once during SAPI init (global state, interned strings)
- ts_resource(0) per-thread to initialize TSRM thread-local storage

The fix:
- Keep php_module_startup() as one-time call in Sapi::new() on main thread
- ThreadScope calls ext_php_rs_sapi_per_thread_init() which calls ts_resource(0)
- Remove Sapi::startup() that was calling php_module_startup() per-request

This properly separates global initialization from per-thread TLS setup.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: Qard

src/embed.rs

@@ -341,16 +341,11 @@ impl Handler for Embed {
 
     // Spawn blocking PHP execution - ALL PHP operations happen here
     let blocking_handle = tokio::task::spawn_blocking(move || {
-      // Keep sapi alive for the duration of this task
-      let sapi = _sapi;
+      // Keep _sapi alive for the duration of the blocking task
+      let _ = &_sapi;
+
       // Initialize thread-local storage for this worker thread
       let _thread_scope = ThreadScope::new();
-      // Call SAPI startup on THIS thread to initialize PHP's memory allocator.
-      // This is required before any estrdup calls can be made.
-      // php_module_startup() sets up per-thread state needed for emalloc/estrdup.
-      sapi.startup().map_err(|_| EmbedRequestError::SapiNotStarted)?;
-      // Keep sapi alive for the duration of this task
-      let _sapi = sapi;
 
       // Setup RequestContext (always streaming from SAPI perspective)
       // RequestContext::new() will extract the request body's read stream and add it as RequestStream extension

src/sapi.rs

@@ -114,24 +114,6 @@ impl Sapi {
     })
   }
 
-  /// Initialize PHP for the current thread and call the SAPI module startup.
-  /// This must be called on each worker thread before using PHP's memory allocator (estrdup).
-  /// On ZTS builds, this initializes thread-local storage and module state.
-  pub fn startup(&self) -> Result<(), EmbedRequestError> {
-    let sapi = &mut self
-      .module
-      .write()
-      .map_err(|_| EmbedRequestError::SapiNotStarted)?;
-
-    if let Some(startup) = sapi.startup {
-      if unsafe { startup(sapi.as_mut()) } != ZEND_RESULT_CODE_SUCCESS {
-        return Err(EmbedRequestError::SapiNotStarted);
-      }
-    }
-
-    Ok(())
-  }
-
   pub fn shutdown(&self) -> Result<(), EmbedRequestError> {
     // Only shutdown if we're on the same thread that created this Sapi
     let current_thread = std::thread::current().id();

src/scopes.rs

@@ -9,8 +9,7 @@ use ext_php_rs::{
   embed::{ext_php_rs_sapi_per_thread_init, ext_php_rs_sapi_per_thread_shutdown},
   ffi::{
     _zend_file_handle__bindgen_ty_1, php_request_shutdown, php_request_startup,
-    zend_destroy_file_handle, zend_file_handle, zend_stream_init_filename,
-    ZEND_RESULT_CODE_SUCCESS,
+    zend_destroy_file_handle, zend_file_handle, zend_stream_init_filename, ZEND_RESULT_CODE_SUCCESS,
   },
 };