Support streams

Author: Qard

.github/workflows/CI.yml

@@ -45,16 +45,6 @@ jobs:
               brew install autoconf automake libtool re2c bison libiconv \
               argon2 libzip postgresql@16
 
-          # TODO: Do we need to care about x86_64 macOS?
-          # NOTE: Unable to force link bison on macOS 13, which php-src requires.
-          - host: macos-13
-            target: x86_64-apple-darwin
-            # build: pnpm build --target x86_64-apple-darwin
-            build: pnpm build
-            setup: |
-              brew install autoconf automake libtool re2c bison libiconv \
-              argon2 libzip postgresql@16
-
           #
           # Linux
           #
@@ -302,11 +292,6 @@ jobs:
       fail-fast: false
       matrix:
         settings:
-          - host: macos-13
-            target: x86_64-apple-darwin
-            architecture: x64
-            setup: |
-              brew install openssl@3 argon2 postgresql@16
           - host: macos-15
             target: aarch64-apple-darwin
             architecture: arm64
@@ -352,8 +337,85 @@ jobs:
       - name: List packages
         run: ls -R ./npm
         shell: bash
+      - name: Show environment info
+        run: |
+          echo "=== macOS Info ==="
+          uname -a
+          sw_vers
+          echo ""
+          echo "=== Node.js ==="
+          node -v
+          echo ""
+          echo "=== OpenSSL (brew) ==="
+          brew info openssl@3 | head -5
+          echo ""
+          echo "=== OpenSSL (node built-in) ==="
+          node -e "console.log(process.versions)"
+          echo ""
+          echo "=== libphp dependencies ==="
+          otool -L npm/darwin-arm64/libphp.dylib | head -20
+          echo ""
+          echo "=== binding.node dependencies ==="
+          otool -L npm/darwin-arm64/binding.node | head -20
       - name: Test bindings
-        run: pnpm test
+        run: |
+          # Run tests with LLDB to catch segfaults on macOS
+          LLDB_OUTPUT=$(mktemp)
+          LLDB_SCRIPT=$(mktemp)
+
+          # Create LLDB command script with stop-hook to automatically get backtraces
+          cat > "$LLDB_SCRIPT" << 'LLDBSCRIPT'
+          settings set auto-confirm true
+          settings set target.process.stop-on-exec false
+
+          # Add a stop hook that runs "bt all" whenever the process stops
+          target stop-hook add -o "bt all"
+
+          # Run the process
+          run
+
+          # After process exits or crashes, get final backtrace and quit
+          bt all
+          quit
+          LLDBSCRIPT
+
+          echo "=== Running tests under LLDB ==="
+
+          # Run LLDB with the script
+          lldb \
+            -s "$LLDB_SCRIPT" \
+            -- node node_modules/ava/entrypoints/cli.mjs __test__/handler.spec.mjs __test__/headers.spec.mjs __test__/request.spec.mjs __test__/response.spec.mjs __test__/rewriter.spec.mjs __test__/streaming.spec.mjs 2>&1 | tee "$LLDB_OUTPUT"
+
+          LLDB_EXIT=$?
+          echo ""
+          echo "=== LLDB exit code: $LLDB_EXIT ==="
+
+          rm -f "$LLDB_SCRIPT"
+
+          # Check for crash indicators in LLDB output
+          if grep -qE "(SIGSEGV|SIGABRT|SIGBUS|EXC_BAD_ACCESS|EXC_CRASH|zend_mm_heap corrupted|stop reason = EXC|stop reason = signal)" "$LLDB_OUTPUT"; then
+            echo ""
+            echo "========================================"
+            echo "=== CRASH DETECTED ==="
+            echo "========================================"
+            echo ""
+            echo "=== Backtrace output should be above ==="
+            rm -f "$LLDB_OUTPUT"
+            exit 1
+          fi
+
+          # Check the output for test results
+          if grep -q "tests passed" "$LLDB_OUTPUT" && ! grep -q "tests failed" "$LLDB_OUTPUT"; then
+            echo "=== Tests passed ==="
+            rm -f "$LLDB_OUTPUT"
+            exit 0
+          fi
+
+          # If we get here, something went wrong
+          echo "=== Test run did not complete successfully ==="
+          cat "$LLDB_OUTPUT"
+          rm -f "$LLDB_OUTPUT"
+          exit 1
 
   test-linux-binding:
     name: Test bindings on ${{ matrix.target }} - node@${{ matrix.node }}
@@ -431,9 +493,34 @@ jobs:
               libcurl4-openssl-dev autoconf libxml2-dev libsqlite3-dev \
               bison re2c libonig-dev libargon2-dev libzip-dev zlib1g-dev \
               openssh-client libclang-dev libreadline-dev libpng-dev \
-              libjpeg-dev libsodium-dev libpq5
-
-            npm run test
+              libjpeg-dev libsodium-dev libpq5 gdb
+
+            # Enable core dumps
+            ulimit -c unlimited
+            echo '/tmp/core.%e.%p' > /proc/sys/kernel/core_pattern || true
+
+            # Run tests with GDB to catch segfaults
+            # Use the ava entrypoint directly instead of the bin script
+            gdb -batch \
+              -ex "set pagination off" \
+              -ex "set confirm off" \
+              -ex "handle SIGSEGV stop print" \
+              -ex "run" \
+              -ex "thread apply all bt full" \
+              --args node node_modules/ava/entrypoints/cli.mjs __test__/handler.spec.mjs __test__/headers.spec.mjs __test__/request.spec.mjs __test__/response.spec.mjs __test__/rewriter.spec.mjs __test__/streaming.spec.mjs
+
+            EXIT_CODE=$?
+            if [ $EXIT_CODE -ne 0 ]; then
+              echo "=== Test failed with exit code $EXIT_CODE ==="
+              # Try to find and analyze core dumps
+              if ls /tmp/core.* 2>/dev/null; then
+                for core in /tmp/core.*; do
+                  echo "=== Analyzing core dump: $core ==="
+                  gdb -batch -ex "bt full" -ex "thread apply all bt" node "$core" || true
+                done
+              fi
+              exit $EXIT_CODE
+            fi
 
   publish:
     name: Publish a release

Cargo.toml

@@ -22,17 +22,19 @@ path = "src/main.rs"
 [dependencies]
 bytes = "1.10.1"
 hostname = "0.4.1"
-ext-php-rs = { version = "0.14.0", features = ["embed"] }
-http-handler = { git = "https://github.com/platformatic/http-handler.git", branch = "core-async-trait" }
+# TODO: Switch back to crates.io once 0.15.3+ is released with ext_php_rs_sapi_per_thread_shutdown
+ext-php-rs = { git = "https://github.com/extphprs/ext-php-rs.git", features = ["embed"] }
+http-body-util = "0.1"
+http-handler = { git = "https://github.com/platformatic/http-handler.git" }
 # http-handler = { path = "../http-handler" }
 http-rewriter = { git = "https://github.com/platformatic/http-rewriter.git" }
 # http-rewriter = { path = "../http-rewriter" }
 libc = "0.2.171"
 # Default enable napi4 feature, see https://nodejs.org/api/n-api.html#node-api-version-matrix
-napi = { version = "3", default-features = false, features = ["napi4"], optional = true }
+napi = { version = "3", default-features = false, features = ["napi4", "tokio_rt", "async"], optional = true }
 napi-derive = { version = "3", optional = true }
 once_cell = "1.21.0"
-tokio = { version = "1.45", features = ["rt", "macros", "rt-multi-thread"] }
+tokio = { version = "1.45", features = ["rt", "macros", "rt-multi-thread", "sync"] }
 regex = "1.0"
 
 [dev-dependencies]

__test__/request.spec.mjs

@@ -10,8 +10,6 @@ test('minimum construction requirements', (t) => {
 
   t.is(req.method, 'GET')
   t.is(req.url, 'http://example.com/test.php')
-  t.assert(req.body instanceof Buffer)
-  t.is(req.body.length, 0)
   t.assert(req.headers instanceof Headers)
   t.is(req.headers.size, 0)
 })

__test__/response.spec.mjs

@@ -9,8 +9,6 @@ test('Minimal response construction', (t) => {
 
   t.is(res.status, 200)
   t.assert(res.headers instanceof Headers)
-  t.assert(res.body instanceof Buffer)
-  t.deepEqual(res.body.toString(), '')
   t.assert(res.log instanceof Buffer)
   t.deepEqual(res.log.toString(), '')
   t.is(res.exception, null)
@@ -37,8 +35,6 @@ test('Full Response construction', (t) => {
   t.assert(res.headers instanceof Headers)
   t.deepEqual(res.headers.get('Content-Type'), 'application/json')
   t.deepEqual(res.headers.getAll('Accept'), ['application/json', 'text/plain'])
-  t.assert(res.body instanceof Buffer)
-  t.deepEqual(res.body.toString(), json)
   t.assert(res.log instanceof Buffer)
   t.deepEqual(res.log.toString(), 'Hello, from error_log!')
   t.deepEqual(res.exception, 'Hello, from PHP!')