Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI erroneously reported migration completed when VM did not exist in PCD #143

Closed
jeremymv2 opened this issue Jan 9, 2025 · 3 comments
Closed
Assignees
Labels
bug Something isn't working cannot reproduce The issue could not be reproduced

Comments

@jeremymv2
Copy link
Collaborator

jeremymv2 commented Jan 9, 2025

Issue:
During a migration of a large batch of VMs, the vJailbreak PODs exhausted the host resources and were evicted/killed from the K3s cluster. This left the migration status in the UI erroneously reporting some VMs had been migrated successfully. The VMs in question did not exist in PCD. This gave the user a very low level of confidence in the tool.

We should prevent this from happening by accurately reflecting migration status and leveraging the PCD API to determine if the VM is indeed instantiated and what its running state is.

@jeremymv2 jeremymv2 added bug Something isn't working UI labels Jan 9, 2025
@anmolsachan anmolsachan added this to the vJailbreak-07.02 milestone Jan 9, 2025
@patil-pratik-87
Copy link
Collaborator

@OmkarDeshpande7 is assigning this to you, as the backend is probably sending an incorrect status.

@jeremymv2
Copy link
Collaborator Author

@patil-pratik-87 before we pass this off to the backend, I want to ensure you have ruled out any way in which the front end could have marked the migration completed without have explicitly received that detail from the backend.

The scenario when this occurred was when the vJailbreak VM had exhausted resources and the K3s cluster had evicted many of the PODs. The PODS were therefore in a disfunctional state. In this scenario, is it possible that the frontend could have erroneously defaulted to completed status if the actual state was undetectable?

@patil-pratik-87
Copy link
Collaborator

patil-pratik-87 commented Jan 31, 2025

@jeremymv2 I was able to reproduce this, the backend is sending the wrong status(Succeeded) on the Migration object, even though the VM is not present on PCD.
Attaching the screenshots.

Image
Image
Image

@OmkarDeshpande7 can you take a look at it?

@sharma-tapas sharma-tapas removed the p0 label Feb 6, 2025
@sharma-tapas sharma-tapas added the cannot reproduce The issue could not be reproduced label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cannot reproduce The issue could not be reproduced
Projects
None yet
Development

No branches or pull requests

5 participants