Skip to content

Commit 7f42224

Browse files
committed
chore: Activate more rector rules
1 parent 3d54e4d commit 7f42224

File tree

3 files changed

+57
-37
lines changed

3 files changed

+57
-37
lines changed

rector.php

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,36 @@
44

55
use Rector\Config\RectorConfig;
66
use Rector\Naming\Rector\Class_\RenamePropertyToMatchTypeRector;
7+
use Rector\Php74\Rector\LNumber\AddLiteralSeparatorToNumberRector;
8+
use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
9+
use Rector\PHPUnit\Rector\Class_\PreferPHPUnitSelfCallRector;
10+
use Rector\PHPUnit\Set\PHPUnitSetList;
711
use Rector\Set\ValueObject\LevelSetList;
812
use Rector\Set\ValueObject\SetList;
13+
use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
914

1015
return static function (RectorConfig $rectorConfig): void {
1116
$rectorConfig->paths([
12-
__DIR__ . '/examples',
1317
__DIR__ . '/src',
1418
__DIR__ . '/tests',
1519
__DIR__ . '/rector.php',
1620
]);
1721

22+
$rectorConfig->phpstanConfig(__DIR__ . '/phpstan.neon.dist');
23+
1824
$rectorConfig->sets([
1925
LevelSetList::UP_TO_PHP_82,
26+
27+
PHPUnitSetList::PHPUNIT_40,
28+
PHPUnitSetList::PHPUNIT_50,
29+
PHPUnitSetList::PHPUNIT_60,
30+
PHPUnitSetList::PHPUNIT_70,
31+
PHPUnitSetList::PHPUNIT_80,
32+
PHPUnitSetList::PHPUNIT_90,
33+
PHPUnitSetList::PHPUNIT_100,
34+
PHPUnitSetList::PHPUNIT_CODE_QUALITY,
35+
PHPUnitSetList::ANNOTATIONS_TO_ATTRIBUTES,
36+
2037
SetList::CODE_QUALITY,
2138
SetList::CODING_STYLE,
2239
SetList::DEAD_CODE,
@@ -28,7 +45,15 @@
2845
SetList::INSTANCEOF,
2946
]);
3047

48+
$rectorConfig->rules([
49+
AddLiteralSeparatorToNumberRector::class,
50+
DeclareStrictTypesRector::class,
51+
PreferPHPUnitSelfCallRector::class,
52+
]);
53+
3154
$rectorConfig->skip([
55+
PreferPHPUnitThisCallRector::class,
56+
// phpcs:ignore Squiz.Arrays.ArrayDeclaration.KeySpecified
3257
RenamePropertyToMatchTypeRector::class => [
3358
__DIR__ . '/tests',
3459
],

src/Array/TraverseLeftRightTree.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77
use function array_pop;
88
use function count;
99

10-
/** @template T of array */
10+
/**
11+
* @see \Plook\Tests\Tree\Array\TraverseLeftRightTreeTest
12+
*
13+
* @template T of array
14+
*/
1115
final class TraverseLeftRightTree
1216
{
1317
/**

tests/Array/TraverseLeftRightTreeTest.php

Lines changed: 26 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,10 @@ static function (array $row) use (&$callOrder): void {
4040
},
4141
);
4242

43-
self::assertSame(
44-
[
45-
'before 1',
46-
'after 1',
47-
],
48-
$callOrder,
49-
);
43+
self::assertSame([
44+
'before 1',
45+
'after 1',
46+
], $callOrder);
5047
}
5148

5249
public function testTraverseTreeWithOneNodeAndOneChild(): void
@@ -71,15 +68,12 @@ static function (array $row) use (&$callOrder): void {
7168
},
7269
);
7370

74-
self::assertSame(
75-
[
76-
'before 1',
77-
'before 2',
78-
'after 2',
79-
'after 1',
80-
],
81-
$callOrder,
82-
);
71+
self::assertSame([
72+
'before 1',
73+
'before 2',
74+
'after 2',
75+
'after 1',
76+
], $callOrder);
8377
}
8478

8579
public function testTraverseTreeWithSevenNodes(): void
@@ -109,24 +103,21 @@ static function (array $row) use (&$callOrder): void {
109103
},
110104
);
111105

112-
self::assertEquals(
113-
[
114-
'before 1',
115-
'before 2',
116-
'before 3',
117-
'after 3',
118-
'before 4',
119-
'after 4',
120-
'after 2',
121-
'before 5',
122-
'before 6',
123-
'after 6',
124-
'before 7',
125-
'after 7',
126-
'after 5',
127-
'after 1',
128-
],
129-
$callOrder,
130-
);
106+
self::assertSame([
107+
'before 1',
108+
'before 2',
109+
'before 3',
110+
'after 3',
111+
'before 4',
112+
'after 4',
113+
'after 2',
114+
'before 5',
115+
'before 6',
116+
'after 6',
117+
'before 7',
118+
'after 7',
119+
'after 5',
120+
'after 1',
121+
], $callOrder);
131122
}
132123
}

0 commit comments

Comments
 (0)