[ORCID] | Edit contributor deletes authenticated ORCID

[Bernardo-f]

Valid Title

• I have updated the title to accurately reflect the bug description

Description

While testing version 3.5 of OJS, we noticed that when removing an article from publication to complete the metadata of its contributors (e.g., adding the ROR of their affiliations), the ORCID ID of the contributor was being deleted.

After further investigation, we confirmed that this happens regardless of whether any of the contributor's fields are edited or not.

Steps to Reproduce

1. Log in as Admin or Editor of a journal.
2. Go to Published Submissions: /dashboard/editorial?currentViewId=published
3. Select an article that has contributors with ORCID IDs.
4. Go to the "Contributors" section.
5. Select a contributor with an authenticated ORCID.
6. Click the "Save" button without making any changes.

Expected Result

The contributor should be editable without removing their ORCID, especially if it has already been authenticated.

Actual Result

The contributor's ORCID is deleted, even if no information was modified.

Environment Details

No response

Application Version

3.5.0-1

Logs

No response

Additional Information

While investigating this issue, we reviewed some components and made a change to the UI-library to store the ORCID value and send it along during updates, since it was not being included in the request payload.

We are not entirely sure if this is the correct behavior, as the ORCID is checked for verification before submission. However, this change helped preserve the ORCID in our case.

Here is the commit we made in a forked version of the UI-library, in case it is useful:

🔗 Bernardo-f/ui-library@307ba7c

Pull Requests

pkp-lib(3.5): #11963
ojs(3.5, submodule update): pkp/ojs#5155
ops(3.5, submodule update): pkp/ops#1118
omp(3.5, submodule update): pkp/omp#2147

[asmecher]

@ewhanson, assigning to you, thanks!

[taslangraham]

Hey @ewhanson, I added PRs for this at #11697 (comment) for stable 3.5. Could you take a look at it, please? If all looks good, then I'll port to main.

The solution I went with was to essentially prevent the contributor endpoints from updating an Author's ORCiD.