#12017 consider only active authors when adding a submission via API

Author: bozana

api/v1/submissions/PKPSubmissionController.php

@@ -54,6 +54,7 @@
 use PKP\mail\mailables\SubmissionSavedForLater;
 use PKP\notification\Notification;
 use PKP\notification\NotificationSubscriptionSettingsDAO;
+use PKP\observers\events\MetadataChanged;
 use PKP\orcid\OrcidManager;
 use PKP\plugins\Hook;
 use PKP\plugins\PluginRegistry;
@@ -68,14 +69,12 @@
 use PKP\security\Role;
 use PKP\security\Validation;
 use PKP\services\PKPSchemaService;
+use PKP\stageAssignment\StageAssignment;
 use PKP\submission\GenreDAO;
 use PKP\submission\PKPSubmission;
 use PKP\submission\reviewAssignment\ReviewAssignment;
 use PKP\submissionFile\SubmissionFile;
 use PKP\userGroup\UserGroup;
-use PKP\observers\events\MetadataChanged;
-use PKP\stageAssignment\StageAssignment;
-
 
 class PKPSubmissionController extends PKPBaseController
 {
@@ -607,7 +606,7 @@ public function add(Request $illuminateRequest): JsonResponse
         $submitterUserGroups = UserGroup::withContextIds($context->getId())
             ->withRoleIds([Role::ROLE_ID_MANAGER, Role::ROLE_ID_AUTHOR])
             ->whereHas('userUserGroups', function ($query) use ($user) {
-                $query->withUserId($user->getId());
+                $query->withUserId($user->getId())->withActive();
             })
             ->get();
 
@@ -1342,7 +1341,7 @@ public function publishPublication(Request $illuminateRequest): JsonResponse
 
         foreach ($stageAssignments as $stageAssignment) {
             $userGroup = $stageAssignment->userGroup;
-            if ($userGroup && $userGroup->roleId === Role::ROLE_ID_AUTHOR){
+            if ($userGroup && $userGroup->roleId === Role::ROLE_ID_AUTHOR) {
                 $stageAssignment->canChangeMetadata = 0;
                 $stageAssignment->save();
             }
@@ -1615,7 +1614,7 @@ public function addContributor(Request $illuminateRequest): JsonResponse
                 Repo::author()->edit($author, ['orcidVerificationRequested']);
                 dispatch(new SendAuthorMail($author, $submissionContext, true));
             } catch (\Exception $exception) {
-                OrcidManager::logError("Could not send email to new author with authorId: {$author->getId()}. Reason: $exception");
+                OrcidManager::logError("Could not send email to new author with authorId: {$author->getId()}. Reason: {$exception}");
             }
         }