#12017 consider only active user roles for settings access user groups

Author: bozana

controllers/grid/settings/roles/form/UserGroupForm.php

@@ -20,6 +20,7 @@
 use APP\core\Request;
 use APP\facades\Repo;
 use APP\template\TemplateManager;
+use Illuminate\Database\Query\Builder;
 use PKP\core\JSONMessage;
 use PKP\db\DAORegistry;
 use PKP\facades\Locale;
@@ -116,7 +117,11 @@ public function initData()
             // Get a list of all settings-accessible user groups for the current user in
             // order to prevent them from locking themselves out by disabling the only one.
             $mySettingsAccessUserGroupIds = UserGroup::withContextIds([$this->getContextId()])
-                ->withUserIds([Application::get()->getRequest()->getUser()->getId()])
+                ->whereHas(
+                    'userUserGroups',
+                    fn (Builder $q) =>
+                    $q->withActive()->withUserIds([Application::get()->getRequest()->getUser()->getId()])
+                )
                 ->get()
                 ->filter(fn ($userGroup) => $userGroup->permitSettings)
                 ->map(fn ($userGroup) => $userGroup->id)