#11885 Implemented edit, delete, and search endpoints for task templates and fixed stageId on add

Hafsa-Naeem · Hafsa-Naeem · commit 779c9b8041fb · 2025-11-10T20:19:19.000+05:00
diff --git a/api/v1/editTaskTemplates/PKPEditTaskTemplateController.php b/api/v1/editTaskTemplates/PKPEditTaskTemplateController.php
@@ -29,6 +29,7 @@
 use PKP\security\authorization\CanAccessSettingsPolicy;
 use PKP\security\authorization\ContextAccessPolicy;
 use PKP\security\Role;
+use PKP\API\v1\editTaskTemplates\formRequests\UpdateTaskTemplate;
 
 class PKPEditTaskTemplateController extends PKPBaseController
 {
@@ -59,6 +60,8 @@ public function getGroupRoutes(): void
         ])->group(function () {
             Route::post('', $this->add(...));
             Route::get('', $this->getMany(...));
+            Route::put('{templateId}', $this->update(...))->whereNumber('templateId');
+            Route::delete('{templateId}', $this->delete(...))->whereNumber('templateId');
         });
     }
 
@@ -93,6 +96,7 @@ public function add(AddTaskTemplate $illuminateRequest): JsonResponse
                 'include' => $validated['include'] ?? false,
                 'description' => $validated['description'] ?? null,
                 'dueInterval' => $validated['dueInterval'] ?? null,
+                'type' => (int) $validated['type'],
             ]);
 
             $tpl->userGroups()->sync($validated['userGroupIds']);
@@ -120,6 +124,9 @@ public function getMany(Request $request): JsonResponse
             ->with('userGroups');
 
         $queryParams = $this->_processAllowedParams($request->query(), [
+            'search',
+            'title',
+            'type',
             'stageId',
             'include',
             'count',
@@ -128,6 +135,20 @@ public function getMany(Request $request): JsonResponse
 
         foreach ($queryParams as $param => $val) {
             switch ($param) {
+                case 'search':
+                    $collector->filterBySearch((string) $val);
+                    break;
+                case 'title':
+                    $collector->filterByTitleLike((string) $val);
+                    break;
+                case 'type':
+                    if (is_numeric($val)) {
+                        $type = (int) $val;
+                        if ($type === Template::TYPE_DISCUSSION || $type === Template::TYPE_TASK) {
+                            $collector->filterByType($type);
+                        }
+                    }
+                    break;
                 case 'stageId':
                     $collector->filterByStageId((int) $val);
                     break;
@@ -156,4 +177,66 @@ public function getMany(Request $request): JsonResponse
             ->setStatusCode(Response::HTTP_OK);
     }
 
+    /**
+     * UPDATE /api/v1/editTaskTemplates/{templateId}
+     */
+    public function update(UpdateTaskTemplate $request): JsonResponse
+    {
+        $contextId = (int) $this->getRequest()->getContext()->getId();
+        $id = (int) $request->route('templateId');
+
+        $template = Template::query()
+            ->where('context_id', $contextId)
+            ->findOrFail($id);
+
+        $data = $request->validated();
+
+        DB::transaction(function () use ($template, $data) {
+            $updates = [];
+            if (array_key_exists('stageId', $data)) $updates['stage_id'] = (int) $data['stageId'];
+            if (array_key_exists('title', $data)) $updates['title'] = $data['title'];
+            if (array_key_exists('include', $data)) $updates['include'] = (bool) $data['include'];
+            if (array_key_exists('emailTemplateKey', $data)) $updates['email_template_key'] = $data['emailTemplateKey'];
+            if (array_key_exists('type', $data)) $updates['type'] = (int) $data['type'];
+
+            if ($updates) {
+                $template->update($updates);
+            }
+            if (array_key_exists('userGroupIds', $data)) {
+                $template->userGroups()->sync($data['userGroupIds']);
+            }
+        });
+
+        return response()->json(
+            (new TaskTemplateResource($template->refresh()->load('userGroups')))->toArray($request),
+            Response::HTTP_OK
+        );
+    }
+
+    /**
+     * DELETE /api/v1/editTaskTemplates/{templateId}
+     */
+    public function delete(Request $illuminateRequest): JsonResponse
+    {
+        $contextId = (int) $this->getRequest()->getContext()->getId();
+        $id = (int) $illuminateRequest->route('templateId');
+
+        $template = Template::query()
+            ->where('context_id', $contextId)
+            ->find($id);
+
+        if (!$template) {
+            return response()->json([
+                'error' => __('api.404.resourceNotFound'),
+            ], Response::HTTP_NOT_FOUND);
+        }
+
+        DB::transaction(function () use ($template) {
+            // Pivot/settings rows cascade via FKs defined in migration
+            $template->delete();
+        });
+
+        return response()->json([], Response::HTTP_OK);
+    }
+
 }
diff --git a/api/v1/editTaskTemplates/formRequests/AddTaskTemplate.php b/api/v1/editTaskTemplates/formRequests/AddTaskTemplate.php
@@ -31,14 +31,22 @@ public function authorize(): bool
     public function rules(): array
     {
         $contextId = Application::get()->getRequest()->getContext()->getId();
-        $stageIds = array_keys(Application::getApplicationStages());
+
+        // build a list of allowed stage IDs from values
+        $stages = Application::getApplicationStages();
+        $stageIds = array_values(array_unique(array_filter(
+            array_map('intval', array_merge(array_keys((array)$stages), array_values((array)$stages))),
+            fn ($id) => $id > 0
+        )));
+
         return [
             'type' => ['required', Rule::in(array_column(EditorialTaskType::cases(), 'value'))],
             'stageId' => ['required', 'integer', Rule::in($stageIds)],
             'title' => ['required', 'string', 'max:255'],
             'include' => ['boolean'],
             'dueInterval' => ['sometimes', 'nullable', 'string', Rule::in(array_column(EditorialTaskDueInterval::cases(), 'value'))],
             'description' => ['sometimes', 'nullable', 'string'],
+            'type' => ['required','integer','in:1,2'],
             'userGroupIds' => ['required', 'array', 'min:1'],
             'userGroupIds.*' => [
                 'integer',
@@ -52,10 +60,12 @@ public function rules(): array
     protected function prepareForValidation(): void
     {
         $stageId = $this->input('stageId', null);
+        $type = $this->input('type', null);
         $this->merge([
             'include' => filter_var($this->input('include', false), FILTER_VALIDATE_BOOLEAN),
             'userGroupIds' => array_values(array_map('intval', (array) $this->input('userGroupIds', []))),
             'stageId' => is_null($stageId) ? $stageId : (int) $stageId,
+            'type' => is_null($type) ? null : (int) $type,
         ]);
     }
 }
diff --git a/api/v1/editTaskTemplates/formRequests/UpdateTaskTemplate.php b/api/v1/editTaskTemplates/formRequests/UpdateTaskTemplate.php
@@ -0,0 +1,85 @@
+<?php
+
+namespace PKP\API\v1\editTaskTemplates\formRequests;
+
+use APP\core\Application;
+use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Validation\Rule;
+
+class UpdateTaskTemplate extends FormRequest
+{
+    public function authorize(): bool
+    {
+        return true;
+    }
+
+    public function rules(): array
+    {
+        $contextId = Application::get()->getRequest()->getContext()->getId();
+
+        // Build allowed stage IDs (values)
+        $stages = Application::getApplicationStages();
+        $stageIds = array_values(array_unique(array_filter(
+            array_map('intval', array_merge(array_keys((array)$stages), array_values((array)$stages))),
+            fn ($id) => $id > 0
+        )));
+
+        // Context-scoped email keys
+        $emailKeys = \APP\facades\Repo::emailTemplate()
+            ->getCollector($contextId)
+            ->getMany()
+            ->map(fn ($t) => $t->getData('key'))
+            ->filter()
+            ->values()
+            ->all();
+
+        return [
+            // all fields are optional but if present must validate
+            'stageId' => ['sometimes', 'integer', Rule::in($stageIds)],
+            'title' => ['sometimes', 'string', 'max:255'],
+            'include' => ['sometimes', 'boolean'],
+            'emailTemplateKey' => ['sometimes', 'nullable', 'string', 'max:255', Rule::in($emailKeys)],
+            'type' => ['sometimes','integer','in:1,2'],
+
+            'userGroupIds' => ['sometimes', 'array', 'min:1'],
+            'userGroupIds.*' => [
+                'integer',
+                'distinct',
+                Rule::exists('user_groups', 'user_group_id')
+                    ->where(fn ($q) => $q->where('context_id', $contextId)),
+            ],
+        ];
+    }
+
+    protected function prepareForValidation(): void
+    {
+        $stageId = $this->input('stageId', null);
+        $type = $this->input('type', null);
+
+        $this->merge([
+            'include' => $this->has('include')
+                ? filter_var($this->input('include'), FILTER_VALIDATE_BOOLEAN)
+                : $this->input('include', null),
+
+            'userGroupIds' => $this->has('userGroupIds')
+                ? array_values(array_map('intval', (array) $this->input('userGroupIds', [])))
+                : $this->input('userGroupIds', null),
+
+            'stageId' => $this->has('stageId')
+                ? (is_null($stageId) ? null : (int) $stageId)
+                : $this->input('stageId', null),
+
+            'type' => $this->has('type')
+                ? (is_null($type) ? null : (int) $type)
+                : $this->input('type', null),
+        ]);
+    }
+
+    protected function passedValidation(): void
+    {
+        if ($this->has('emailTemplateKey')) {
+            $key = $this->input('emailTemplateKey');
+            $this->merge(['emailTemplateKey' => is_string($key) ? trim($key) : $key]);
+        }
+    }
+}
diff --git a/api/v1/editTaskTemplates/resources/TaskTemplateResource.php b/api/v1/editTaskTemplates/resources/TaskTemplateResource.php
@@ -31,6 +31,7 @@ public function toArray(Request $request)
             'include' => (bool) $this->include,
             'dueInterval' => $this->dueInterval,
             'description' => $this->description,
+            'type' => (int) $this->type,
             'userGroups' => $this->whenLoaded(
                 'userGroups',
                 fn () => $this->userGroups
diff --git a/classes/editorialTask/Template.php b/classes/editorialTask/Template.php
@@ -27,6 +27,7 @@
 use PKP\editorialTask\EditorialTask as Task;
 use PKP\stageAssignment\StageAssignment;
 use PKP\userGroup\UserGroup;
+use Illuminate\Support\Facades\DB;
 
 class Template extends Model
 {
@@ -37,6 +38,9 @@ class Template extends Model
 
     public $timestamps = true;
 
+    public const TYPE_DISCUSSION = 1;
+    public const TYPE_TASK = 2;
+
     // columns on edit_task_templates
     protected $fillable = [
         'stageId',
@@ -53,6 +57,7 @@ class Template extends Model
         'context_id' => 'int',
         'include' => 'bool',
         'title' => 'string',
+        'type' => 'int',
     ];
 
     /**
@@ -172,4 +177,69 @@ public function promote(Submission $submission): Task
         ]);
     }
 
+    /**
+     * Scope: filter by  type
+     */
+    public function scopeFilterByType(Builder $q, int $type): Builder
+    {
+        return $q->where('type', $type);
+    }
+
+    /**
+     * Scope: filter by title LIKE
+     */
+    public function scopeFilterByTitleLike(Builder $query, string $title): Builder
+    {
+        $title = trim($title);
+        if ($title === '') {
+            return $query;
+        }
+        $needle = '%' . str_replace(['%', '_'], ['\\%', '\\_'], mb_strtolower($title)) . '%';
+        return $query->whereRaw('LOWER(title) LIKE ?', [$needle]);
+    }
+
+    /**
+     * free-text/ words search across:
+     * title column
+     * name, description
+     * email_template_key column
+     *
+     */
+    public function scopeFilterBySearch(Builder $query, string $phrase): Builder
+    {
+        $phrase = trim($phrase);
+        if ($phrase === '') {
+            return $query;
+        }
+
+        $tokens = preg_split('/\s+/', $phrase) ?: [];
+        $tokens = array_values(array_filter($tokens, fn ($t) => $t !== ''));
+        if (!$tokens) {
+            return $query;
+        }
+
+        $settingsTable = $this->getSettingsTable(); // 'edit_task_template_settings'
+        $pk = $this->getKeyName(); // 'edit_task_template_id'
+        $selfTable = $this->getTable(); // 'edit_task_templates'
+
+        return $query->where(function (Builder $outer) use ($tokens, $settingsTable, $pk, $selfTable) {
+            foreach ($tokens as $tok) {
+                // escape % and _
+                $like = '%' . str_replace(['%', '_'], ['\\%', '\\_'], mb_strtolower($tok)) . '%';
+
+                $outer->where(function (Builder $q) use ($like, $settingsTable, $pk, $selfTable) {
+                    $q->whereRaw('LOWER(title) LIKE ?', [$like])
+                    ->orWhereRaw('LOWER(email_template_key) LIKE ?', [$like])
+                    ->orWhereExists(function ($sub) use ($like, $settingsTable, $pk, $selfTable) {
+                        $sub->select(DB::raw(1))
+                            ->from($settingsTable . ' as ets')
+                            ->whereColumn("ets.$pk", "$selfTable.$pk")
+                            ->whereIn('ets.setting_name', ['name', 'description'])
+                            ->whereRaw('LOWER(ets.setting_value) LIKE ?', [$like]);
+                    });
+                });
+            }
+        });
+    }
+
 }
diff --git a/classes/migration/upgrade/v3_6_0/I11885_AddTypeToEditTaskTemplates.php b/classes/migration/upgrade/v3_6_0/I11885_AddTypeToEditTaskTemplates.php
@@ -0,0 +1,45 @@
+<?php
+
+namespace PKP\migration\upgrade\v3_6_0;
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Schema;
+
+class I11885_AddTypeToEditTaskTemplates extends Migration
+{
+    public function up(): void
+    {
+        // add column with default
+        Schema::table('edit_task_templates', function (Blueprint $table) {
+            if (!Schema::hasColumn('edit_task_templates', 'type')) {
+                $table->unsignedSmallInteger('type')->default(1);
+            }
+        });
+
+        // backfill if any task exists with type=2 for a template, set that template to 2
+        DB::table('edit_task_templates as ett')
+            ->whereExists(function ($q) {
+                $q->select(DB::raw(1))
+                  ->from('edit_tasks as et')
+                  ->whereColumn('et.edit_task_template_id', 'ett.edit_task_template_id')
+                  ->where('et.type', 2);
+            })
+            ->update(['type' => 2]);
+
+        // index to speed filtering (context + type + stage)
+        try {
+            Schema::table('edit_task_templates', function (Blueprint $table) {
+                $table->index(['context_id', 'type', 'stage_id'], 'ett_context_type_stage_idx');
+            });
+        } catch (\Throwable $e) {
+            // index may already exist.. ignore
+        }
+    }
+
+    public function down(): void
+    {
+        throw new \PKP\install\DowngradeNotSupportedException();
+    }
+}
