#11885 Simplify stage casting logic and ensure consistent case-folding in template search

Author: Hafsa-Naeem

api/v1/editTaskTemplates/formRequests/TaskTemplateRequestTrait.php

@@ -27,13 +27,7 @@ protected function getContextId(): int
 
     protected function getStageIds(): array
     {
-        $stages = Application::getApplicationStages();
-
-        return array_values(
-            array_unique(
-                array_map('intval', array_values((array) $stages))
-            )
-        );
+        return Application::getApplicationStages();
     }
 
     protected function userGroupIdsItemRules(int $contextId): array

classes/editorialTask/Template.php

@@ -245,17 +245,17 @@ public function scopeFilterBySearch(Builder $query, string $phrase): Builder
 
             $query->where(function (Builder $outer) use ($keywords, $settingsTable, $pk, $selfTable) {
                 foreach ($keywords as $tok) {
-                    $like = '%' . str_replace(['%', '_'], ['\\%', '\\_'], mb_strtolower($tok, 'UTF-8')) . '%';
+                    $like = '%' . addcslashes($tok, '%_') . '%';
 
                     $outer->where(function (Builder $q) use ($like, $settingsTable, $pk, $selfTable) {
-                        $q->whereRaw('LOWER(title) LIKE ?', [$like])
-                            ->orWhereRaw('LOWER(description) LIKE ?', [$like])
+                        $q->whereRaw('LOWER(title) LIKE LOWER(?)', [$like])
+                            ->orWhereRaw('LOWER(description) LIKE LOWER(?)', [$like])
                             ->orWhereExists(function ($sub) use ($like, $settingsTable, $pk, $selfTable) {
                                 $sub->select(DB::raw(1))
                                     ->from($settingsTable . ' as ets')
                                     ->whereColumn("ets.$pk", "$selfTable.$pk")
                                     ->whereIn('ets.setting_name', ['name', 'description'])
-                                    ->whereRaw('LOWER(ets.setting_value) LIKE ?', [$like]);
+                                    ->whereRaw('LOWER(ets.setting_value) LIKE LOWER(?)', [$like]);
                             });
                     });
                 }