fix(self_update): use semver version comparison

Author: QaidVoid

.github/workflows/release-plz.yml

@@ -9,6 +9,8 @@ jobs:
   release-plz-release:
     name: Release-plz release
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

.release-plz.toml

@@ -59,18 +59,6 @@ body = """
         {% endif -%}
     {% endfor -%}
 {% endfor -%}
-{%- if remote.contributors %}
-### Contributors
-{% for contributor in remote.contributors %}
-    * @{{ contributor.username }}
-{%- endfor %}
-{% endif -%}
-{%- macro username(commit) -%}
-    {% if commit.remote.username %} (by @{{ commit.remote.username }}){% endif -%}
-{% endmacro -%}
-{%- macro pr(commit) -%}
-    {% if commit.remote.pr_number %} - #{{ commit.remote.pr_number }}{% endif -%}
-{% endmacro -%}
 """
 trim = true
 commit_parsers = [

Cargo.lock

@@ -27,6 +27,7 @@ rayon = { workspace = true }
 regex = { workspace = true }
 reqwest = { workspace = true }
 rusqlite = { workspace = true }
+semver = "1.0.25"
 serde = { workspace = true }
 serde_json = { workspace = true }
 soar-core = { version = "0.1.10", path = "../soar-core" }

soar-cli/Cargo.toml

@@ -3,6 +3,7 @@ use std::{
     fs,
 };
 
+use semver::Version;
 use soar_core::{error::ErrorContext, SoarResult};
 use soar_dl::{
     downloader::{DownloadOptions, Downloader},
@@ -38,8 +39,17 @@ pub async fn process_self_action(action: &SelfAction) -> SoarResult<()> {
                 if target_nightly {
                     is_nightly_release && rel.name() != self_version
                 } else {
-                    !is_nightly_release
-                        && (is_nightly || rel.tag_name().trim_start_matches("v") > self_version)
+                    let release_version = rel.tag_name().trim_start_matches("v");
+
+                    let release_version = Version::parse(release_version).ok();
+                    let self_version = Version::parse(self_version).ok();
+
+                    match (release_version, self_version) {
+                        (Some(release_ver), Some(self_ver)) => {
+                            !is_nightly_release && (is_nightly || release_ver > self_ver)
+                        }
+                        _ => false,
+                    }
                 }
             });