Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Form add and edit Application for piped v1 #5509

Closed
hongky-1994 opened this issue Jan 23, 2025 · 0 comments · Fixed by #5516
Closed

Update Form add and edit Application for piped v1 #5509

hongky-1994 opened this issue Jan 23, 2025 · 0 comments · Fixed by #5516
Assignees

Comments

@hongky-1994
Copy link
Contributor

@hongky-1994 will keep working on the UI update for piped v1

PlatformProvider; UI

Purpose

Mostly related to 2 model applications and deployment

Used in

  • API call AddApplication, UpdateApplication
  • For showing in Application, Deployment detail page

The source fetched to used in the drawer is come from the piped configuration

https://github.com/pipe-cd/pipecd/blob/master/web/src/components/application-form/index.tsx#L58-L80

Modification idea

  • Keep it as in the application and deployment model
  • Also, keep the configuration and parser for pipedv0 config the same as it is (no UI affected around that fetch)
  • Make a new Add Application form/suggestion form that doesn't show any platform provider-related information

Originally posted by @khanhtc1202 in #5252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant