Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each component instance creates it's own stylesheet when using string stylesheets #52

Closed
cristinecula opened this issue Dec 4, 2024 · 1 comment
Closed

Each component instance creates it's own stylesheet when using string stylesheets #52

cristinecula opened this issue Dec 4, 2024 · 1 comment
Assignees
@megheaiulian
Labels
bug Something isn't working

Comments

@cristinecula
Copy link
Contributor

cristinecula commented Dec 4, 2024 •
edited
Loading

We should create the sheets only once and re-use them.

pion/src/component.ts

Line 120 in f562ddb

if (styleSheets) shadowRoot.adoptedStyleSheets = sheets(styleSheets);

@cristinecula cristinecula changed the title Each component instance has it's own stylesheet When using string stylesheets Each component instance creates it's own stylesheet when using string stylesheets Dec 4, 2024
@cristinecula cristinecula added the bug Something isn't working label Dec 4, 2024
@megheaiulian
Copy link
Contributor

fixed by #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@megheaiulian megheaiulian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cristinecula @megheaiulian