Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missiles buttons not showing up #5887

Closed
lolo101 opened this issue Aug 9, 2024 · 5 comments · Fixed by #5734
Closed

Missiles buttons not showing up #5887

lolo101 opened this issue Aug 9, 2024 · 5 comments · Fixed by #5734

Comments

@lolo101
Copy link
Contributor

lolo101 commented Aug 9, 2024

Observed behaviour

I have 6 smart missiles loaded in my ship
However in the HUD, the missile button is absent, so I cannot fire them

Note that on a previous flight, I had guided missiles and the butotn showed up correctly

button missing:
image

But missiles loaded:
image

Expected behaviour

The missile button is present so I can fire them

Steps to reproduce

Just load the savegame

My pioneer version (and OS):

20240710 (e123a3f) (Linux)

My output.txt (required) and game save (optional, but recommended)
output.txt
lolo2.gz

@impaktor
Copy link
Member

impaktor commented Aug 9, 2024

I assume this issue will be fixed by the weapon re-write that's in the pipe line (assuming time & motivation to finish it).

@lolo101
Copy link
Contributor Author

lolo101 commented Aug 9, 2024

Note: I could fire a missile with the shortcut key.
Later I bought another smart missile to replace the one I used, and then the button showed up but displayed only 1 available missile whereas 6 of them were loaded into the ship

@sturnclaw
Copy link
Member

This is a bug with the current equipment system. A rewrite is in progress and is targeted for merge before the next major update.

@dr-pegasus
Copy link

dr-pegasus commented Sep 30, 2024

I think the problem lies in that the missile equipment slot is not always sorted, and is not sorted right after firing - causing the gui LUA script to have trouble doing a missile headcount.
A dirty quick-fix would be replacing ipairs() with pairs() in \data\pigui\modules\equipment.lua
in
local function displayMissiles(uiPos)

@sturnclaw sturnclaw linked a pull request Oct 1, 2024 that will close this issue
26 tasks
@sturnclaw
Copy link
Member

Note that the underlying cause of this issue is already fixed in #5734.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants