Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trifecta of bugs revealed in sectorview (F2) #4815

Closed
impaktor opened this issue Feb 26, 2020 · 3 comments
Closed

Trifecta of bugs revealed in sectorview (F2) #4815

impaktor opened this issue Feb 26, 2020 · 3 comments

Comments

@impaktor
Copy link
Member

Ship jump status

When preparing #4814, I noticed the jump state shown in the search match list (see screenshot in that PR) is sometimes wrong, and reproducible so:

  1. Start new game at Bernard's Star
  2. Go to sector view, search for some system. You'll see the "NO_DRIVE" (if on current master) suffixed for all suggested star system matches, as is correct.
  3. Start new game from e.g. Sol, repeat 2 above, but now you have a hyperdirve, yet, you still get the "NO_DRIVE" message.

This doesn't happen if starting from Sol directly when starting a pioneer session.

Draw vertical lines

This is what I suspect is happening (I haven't tested it much): When opening sectorview and the default selected system is below the plane, it draws vertical lines even if the lines are turned off. One has to turn them on, then off again to remove them. This is easily reproducible by starting new game (assuming you have vertical line drawing turned off) at New Hope and opening sectorview, then Epsilon Eridani is selected, and there be vertical lines in great abundance.

Remember settings between pioneer sessions

Every time I start a new game in pioneer, the option "Label uninhabited systems" is ticked. Me thinks once I un-tick it, it aught to remember that for next session. I think our pigui supports storing variables, right?

My version

Current master: b08c31f

@craigo-
Copy link
Contributor

craigo- commented Jun 25, 2020

Re your second point, see also issue #4708.

Issues #4675, #4676, #4803 are other examples of things not quite going right when starting a new game or loading a saved game. It seems to be far-reaching.

I noticed another one today in a recent master regarding the orientation and registration of the spinning model in the Ship Information screen... I'll create a separate issue for it.

@Gliese852
Copy link
Contributor

Partially #4708 will be fixed in #4852, settings are not yet saved to the savefile, but remain constant until the program exits

@impaktor
Copy link
Member Author

Remaining bugs tracked in #5178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants