Skip to content

Commit 107a1cd

Browse files
fix assertions in embed integration tests
1 parent 77a2118 commit 107a1cd

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

tests/integration/control/resources/index/test_configure.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def test_configure_index_embed(self, pc, create_sl_index_params):
4747
create_sl_index_params["dimension"] = 1024
4848
pc.db.index.create(**create_sl_index_params)
4949
desc = pc.db.index.describe_index(name)
50-
assert desc.embed == None
50+
assert desc.embed is None
5151

5252
embed_config = {
5353
"model": "multilingual-e5-large",
@@ -58,11 +58,13 @@ def test_configure_index_embed(self, pc, create_sl_index_params):
5858
desc = pc.db.index.describe_index(name)
5959
assert desc.embed.model == "multilingual-e5-large"
6060
assert desc.embed.field_map == {"text": "chunk_text"}
61-
assert desc.embed.read_parameters == {}
62-
assert desc.embed.write_parameters == {}
61+
assert desc.embed.read_parameters == {"input_type": "query", "truncate": "END"}
62+
assert desc.embed.write_parameters == {
63+
"input_type": "passage",
64+
"truncate": "END",
65+
}
6366
assert desc.embed.vector_type == "dense"
6467
assert desc.embed.dimension == 1024
6568
assert desc.embed.metric == "cosine"
66-
assert desc.embed.model_type == "dense"
6769

6870
pc.db.index.delete_index(name)

tests/integration/control/serverless/test_configure_index_embed.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ def test_convert_index_to_integrated(self, client, create_sl_index_params):
44
create_sl_index_params["dimension"] = 1024
55
client.create_index(**create_sl_index_params)
66
desc = client.describe_index(name)
7-
assert desc.embed == None
7+
assert desc.embed is None
88

99
embed_config = {
1010
"model": "multilingual-e5-large",
@@ -15,11 +15,13 @@ def test_convert_index_to_integrated(self, client, create_sl_index_params):
1515
desc = client.describe_index(name)
1616
assert desc.embed.model == "multilingual-e5-large"
1717
assert desc.embed.field_map == {"text": "chunk_text"}
18-
assert desc.embed.read_parameters == {}
19-
assert desc.embed.write_parameters == {}
18+
assert desc.embed.read_parameters == {"input_type": "query", "truncate": "END"}
19+
assert desc.embed.write_parameters == {
20+
"input_type": "passage",
21+
"truncate": "END",
22+
}
2023
assert desc.embed.vector_type == "dense"
2124
assert desc.embed.dimension == 1024
2225
assert desc.embed.metric == "cosine"
23-
assert desc.embed.model_type == "dense"
2426

2527
client.delete_index(name)

tests/integration/control_asyncio/test_configure_index_embed.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ async def test_convert_index_to_integrated(self, create_sl_index_params):
88
create_sl_index_params["dimension"] = 1024
99
await pc.create_index(**create_sl_index_params)
1010
desc = await pc.describe_index(name)
11-
assert desc.embed == None
11+
assert desc.embed is None
1212

1313
embed_config = {
1414
"model": "multilingual-e5-large",
@@ -19,11 +19,13 @@ async def test_convert_index_to_integrated(self, create_sl_index_params):
1919
desc = await pc.describe_index(name)
2020
assert desc.embed.model == "multilingual-e5-large"
2121
assert desc.embed.field_map == {"text": "chunk_text"}
22-
assert desc.embed.read_parameters == {}
23-
assert desc.embed.write_parameters == {}
22+
assert desc.embed.read_parameters == {"input_type": "query", "truncate": "END"}
23+
assert desc.embed.write_parameters == {
24+
"input_type": "passage",
25+
"truncate": "END",
26+
}
2427
assert desc.embed.vector_type == "dense"
2528
assert desc.embed.dimension == 1024
2629
assert desc.embed.metric == "cosine"
27-
assert desc.embed.model_type == "dense"
2830

2931
await pc.delete_index(name)

0 commit comments

Comments
 (0)