Skip to content

Commit 8034dab

Browse files
authored
Update pinecone client version to 1.2.2 and remove redundant client version declaration (#139)
## Problem Prepare for releasing v1.2.2 and remove some redundancies when it comes to declaring pinecone client version in the config and unit tests. ## Solution Update pineconeClientVersion to v1.2.2 and remove redundancies for updating pineconeClientVersion. ## Type of Change - [X] None of the above: Refactoring codebase and updating client version. ## Test Plan Ran unit tests and tested with a locally published jar.
1 parent fb4fb48 commit 8034dab

File tree

7 files changed

+18
-8
lines changed

7 files changed

+18
-8
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
[comment]: <> (When bumping [pc:VERSION_LATEST_RELEASE] create a new entry below)
44
### Unreleased version
5+
### 1.2.2
6+
- Add support for proxy configuration
7+
- Fix user-agent for grpc
8+
59
### 1.2.1
610
- Fix uber jar
711

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,20 @@ Maven:
1515
<dependency>
1616
<groupId>io.pinecone</groupId>
1717
<artifactId>pinecone-client</artifactId>
18-
<version>1.2.1</version>
18+
<version>1.2.2</version>
1919
</dependency>
2020
```
2121

2222
[comment]: <> (^ [pc:VERSION_LATEST_RELEASE])
2323

2424
Gradle:
2525
```
26-
implementation "io.pinecone:pinecone-client:1.2.1"
26+
implementation "io.pinecone:pinecone-client:1.2.2"
2727
```
2828

2929
[comment]: <> (^ [pc:VERSION_LATEST_RELEASE])
3030

31-
Alternatively, you can use our standalone uberjar [pinecone-client-1.2.1-all.jar](https://repo1.maven.org/maven2/io/pinecone/pinecone-client/1.2.1/pinecone-client-1.2.1-all.jar), which bundles the pinecone
31+
Alternatively, you can use our standalone uberjar [pinecone-client-1.2.2-all.jar](https://repo1.maven.org/maven2/io/pinecone/pinecone-client/1.2.2/pinecone-client-1.2.2-all.jar), which bundles the pinecone
3232
client and all dependencies together. You can include this in your classpath like you do with any 3rd party JAR without
3333
having to obtain the *pinecone-client* dependencies separately.
3434

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
pineconeClientVersion = 1.2.1
1+
pineconeClientVersion = 1.2.2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package io.pinecone.commons;
2+
3+
public class Constants {
4+
public static final String pineconeClientVersion = "v1.2.2";
5+
}

src/main/java/io/pinecone/configs/PineconeConfig.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import io.grpc.ManagedChannel;
44
import io.pinecone.exceptions.PineconeConfigurationException;
55

6+
import static io.pinecone.commons.Constants.pineconeClientVersion;
7+
68
/**
79
* The {@link PineconeConfig} class is responsible for managing the configuration settings
810
* required to interact with the Pinecone API. It provides methods to set and retrieve
@@ -206,7 +208,7 @@ public String getUserAgent() {
206208
}
207209

208210
private String buildUserAgent() {
209-
String userAgent = String.format("lang=java; %s=%s", "pineconeClientVersion", "v1.2.1");
211+
String userAgent = String.format("lang=java; %s=%s", "pineconeClientVersion", pineconeClientVersion);
210212
if (this.getSourceTag() != null && !this.getSourceTag().isEmpty()) {
211213
userAgent += "; source_tag=" + this.getSourceTag();
212214
}

src/test/java/io/pinecone/PineconeBuilderTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
import java.nio.file.Paths;
1414
import java.util.AbstractMap;
1515

16+
import static io.pinecone.commons.Constants.pineconeClientVersion;
1617
import static org.junit.jupiter.api.Assertions.*;
1718
import static org.mockito.Mockito.*;
1819

1920
public class PineconeBuilderTest {
2021
private static final Gson gson = new Gson();
21-
private static final String pineconeClientVersion = "v1.2.1";
2222

2323
private static AbstractMap.SimpleEntry<Call, OkHttpClient> buildMockCallAndClient(ResponseBody response) throws IOException {
2424
Response mockResponse = new Response.Builder()

src/test/java/io/pinecone/PineconeConfigTest.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,11 @@
44
import io.pinecone.exceptions.PineconeConfigurationException;
55
import org.junit.jupiter.api.Test;
66

7+
import static io.pinecone.commons.Constants.pineconeClientVersion;
78
import static org.junit.jupiter.api.Assertions.assertEquals;
89

910
public class PineconeConfigTest {
1011

11-
private static final String pineconeClientVersion = "v1.2.1";
12-
1312
@Test
1413
public void testValidateWithNullApiKey() {
1514
try {

0 commit comments

Comments
 (0)