Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Apple Music pages open iTunes even if extension is active #13

Open
theld07 opened this issue Oct 29, 2017 · 3 comments
Open

Apple Music pages open iTunes even if extension is active #13

theld07 opened this issue Oct 29, 2017 · 3 comments
Milestone

Comments

@theld07
Copy link

theld07 commented Oct 29, 2017

The Apple Music webpage will fire up iTunes. it seems that the extension stopped working. My console reports an error while executing the extension's code:

TypeError: null is not an object (evaluating 'bodyOnload.value')

This error appears to occur on line 319:

url = stringClean(bodyOnload.value);

@pichfl
Copy link
Owner

pichfl commented Oct 29, 2017

Can you link the webpage where this happens?

@theld07
Copy link
Author

theld07 commented Oct 29, 2017 via email

@pichfl pichfl changed the title iTunes is opening even if the extension is turned on Apple Music pages open iTunes even if extension is active Oct 29, 2017
@pichfl
Copy link
Owner

pichfl commented Oct 29, 2017

The extension is not yet updated for Apple Music as it was not available when I last updated this project. Since I'm looking into what should become of this extension I'll especially consider this behavior.

Can confirm that this is happening for pages like https://itunes.apple.com/de/album/chantaje-feat-maluma/id1234665555?i=1234665569&app=music&upsell=true&ign-itscg=30201&ign-mpt=uo%3D5

@pichfl pichfl added this to the 2.0.0 Store No More milestone Oct 29, 2017
jdf221 added a commit that referenced this issue Aug 19, 2018
…More

+ Info text inserted: "NoMoreiTunes prevented this page from opening an app" is inserted into pages that are prevented from doing something
+ Support for phobos.apple.com
+ Fixes #7
+ Fixes #6
+ Fixes #13
+ Fixes #15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants