-
Notifications
You must be signed in to change notification settings - Fork 21
Support negative lags in RV calculation #35
Copy link
Copy link
Open
Labels
EnhancementNew feature or requestNew feature or requestGood first issueGood for newcomersGood for newcomers
Description
Detailed Description
Currently, only positive lags are supported in RV calculation:
| delays = [abs(int(lag * samplerate)) for lag in lags] |
However, apply_lags() supports negative lags just fine.
Context / Motivation
I require this for an analysis, and there is no real cost. In fact, as it is implemented, it could be confusing for users.
Possible Implementation
I think it's pretty straightforward to fix:
delays = [int(lag * samplerate) for lag in lags] Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
EnhancementNew feature or requestNew feature or requestGood first issueGood for newcomersGood for newcomers
Type
Projects
Status
To Do