Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Docusaurus v3 #13

Closed
ezzatron opened this issue Nov 16, 2023 · 8 comments · Fixed by #15
Closed

Support for Docusaurus v3 #13

ezzatron opened this issue Nov 16, 2023 · 8 comments · Fixed by #15

Comments

@ezzatron
Copy link

I recently tried upgrading some Docusaurus sites I maintain to v3, and it seems like remark-typescript-tools doesn't work so well with Docusaurus v3 (or maybe MDX v3?). Here are some screenshots to illustrate what happens:


The import statements appear as plain text:

Screenshot 2023-11-16 at 12 53 06

So do the actual Tabs and TabItem components:

Screenshot 2023-11-16 at 12 54 00

Just checking if you're planning on supporting Docusarus v3? Thanks!

@phryneas
Copy link
Owner

As long as Redux Toolkit is on Docusaurus 2, I probably won't add support myself - but I'd be open to PRs.

One thing though: this looks like the output of this plugin isn't being parsed as mdx. There's not a lot this plugin can change about that in the first place - but maybe you were testing this in a .md file, not a .mdx file?

@ezzatron
Copy link
Author

maybe you were testing this in a .md file, not a .mdx file?

Unfortunately, it is .mdx: https://github.com/snout-router/regexp/blob/main/docs/api/function/escape.mdx

@aryaemami59
Copy link
Contributor

Having the same issue, the code compiles just fine, but the tabs are not parsed.
screencapture-localhost-3000-introduction-basic-usage-2023-11-21-16_24_09

@phryneas
Copy link
Owner

Seems like for Docusaurus 3, we need to pre-parse the JSX nodes we insert: facebook/docusaurus#9337

@phryneas
Copy link
Owner

I believe #14 might fix this, but I have no Docusaurus 3 project. Could someone try it and report back?

@phryneas
Copy link
Owner

@aryaemami59 I believe you were setting something up for reselect?

@aryaemami59
Copy link
Contributor

@aryaemami59 I believe you were setting something up for reselect?

Yes sir, I'm looking at the potential memory leak problem in reselect at the moment, when I'm done I'll try running the docs and let you know the results.

@aryaemami59
Copy link
Contributor

@phryneas I am so sorry I got caught up in other things and forgot about this, I just tested it and yes #14 fixes it. It is now compatible with docusaurus v3. You should be all good to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants