Skip to content
This repository was archived by the owner on Dec 6, 2019. It is now read-only.
This repository was archived by the owner on Dec 6, 2019. It is now read-only.

Code Review #118

@Oxymoron290

Description

@Oxymoron290

on app.config.php

There is not setting for CURRENT_SKIN - why?
Possibility for conflicting values between lines 163-171 and lines 57-59 - why?
Line 187, 192, 319, 325, 327, 330, 332, 337, 536 and 537 is using a string literal directory separator instead of the defined DS global - why?
line 187 is using a string literal directory separator instead of the defined DS global - why?
line 319 is using a string literal directory separator instead of the defined DS global - why?

There is a configuration setting for BASE_TEMPLATE_PATH, but not one for admin - WHY?

Lines 327, and 337 use the same value, Why not copy the code from the condition above on line 335? Config::Get('BASE_TEMPLATE_PATH');

permission description array is missing MAINTENANCE Description (i know, that's partially my fault.

bootstrap.inc.php

lines 22, 27, is using a string literal directory separator instead of the defined DS global - why?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions