Skip to content

Commit 84541f0

Browse files
committed
Improve compatibility with nikic/php-parser 4.13.0
1 parent a0ce7fd commit 84541f0

23 files changed

+55
-55
lines changed

src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function processNode(Node $node, Scope $scope): array
4545
return [];
4646
}
4747

48-
if ($node->name->name !== 'get' || !isset($node->args[0])) {
48+
if ($node->name->name !== 'get' || !isset($node->getArgs()[0])) {
4949
return [];
5050
}
5151

@@ -72,7 +72,7 @@ public function processNode(Node $node, Scope $scope): array
7272
return [];
7373
}
7474

75-
$serviceId = $this->serviceMap::getServiceIdFromNode($node->args[0]->value, $scope);
75+
$serviceId = $this->serviceMap::getServiceIdFromNode($node->getArgs()[0]->value, $scope);
7676
if ($serviceId !== null) {
7777
$service = $this->serviceMap->getService($serviceId);
7878
if ($service !== null && !$service->isPublic()) {

src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function processNode(Node $node, Scope $scope): array
5050
return [];
5151
}
5252

53-
if ($node->name->name !== 'get' || !isset($node->args[0])) {
53+
if ($node->name->name !== 'get' || !isset($node->getArgs()[0])) {
5454
return [];
5555
}
5656

@@ -73,10 +73,10 @@ public function processNode(Node $node, Scope $scope): array
7373
return [];
7474
}
7575

76-
$serviceId = $this->serviceMap::getServiceIdFromNode($node->args[0]->value, $scope);
76+
$serviceId = $this->serviceMap::getServiceIdFromNode($node->getArgs()[0]->value, $scope);
7777
if ($serviceId !== null) {
7878
$service = $this->serviceMap->getService($serviceId);
79-
$serviceIdType = $scope->getType($node->args[0]->value);
79+
$serviceIdType = $scope->getType($node->getArgs()[0]->value);
8080
if ($service === null && !$scope->getType(Helper::createMarkerNode($node->var, $serviceIdType, $this->printer))->equals($serviceIdType)) {
8181
return [sprintf('Service "%s" is not registered in the container.', $serviceId)];
8282
}

src/Rules/Symfony/InvalidArgumentDefaultValueRule.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ public function processNode(Node $node, Scope $scope): array
4646
if (!$node->name instanceof Node\Identifier || $node->name->name !== 'addArgument') {
4747
return [];
4848
}
49-
if (!isset($node->args[3])) {
49+
if (!isset($node->getArgs()[3])) {
5050
return [];
5151
}
5252

53-
$modeType = isset($node->args[1]) ? $scope->getType($node->args[1]->value) : new NullType();
53+
$modeType = isset($node->getArgs()[1]) ? $scope->getType($node->getArgs()[1]->value) : new NullType();
5454
if ($modeType instanceof NullType) {
5555
$modeType = new ConstantIntegerType(2); // InputArgument::OPTIONAL
5656
}
@@ -63,7 +63,7 @@ public function processNode(Node $node, Scope $scope): array
6363
}
6464
$mode = $modeTypes[0]->getValue();
6565

66-
$defaultType = $scope->getType($node->args[3]->value);
66+
$defaultType = $scope->getType($node->getArgs()[3]->value);
6767

6868
// not an array
6969
if (($mode & 4) !== 4 && !(new UnionType([new StringType(), new NullType()]))->isSuperTypeOf($defaultType)->yes()) {

src/Rules/Symfony/InvalidOptionDefaultValueRule.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@ public function processNode(Node $node, Scope $scope): array
4848
if (!$node->name instanceof Node\Identifier || $node->name->name !== 'addOption') {
4949
return [];
5050
}
51-
if (!isset($node->args[4])) {
51+
if (!isset($node->getArgs()[4])) {
5252
return [];
5353
}
5454

55-
$modeType = isset($node->args[2]) ? $scope->getType($node->args[2]->value) : new NullType();
55+
$modeType = isset($node->getArgs()[2]) ? $scope->getType($node->getArgs()[2]->value) : new NullType();
5656
if ($modeType instanceof NullType) {
5757
$modeType = new ConstantIntegerType(1); // InputOption::VALUE_NONE
5858
}
@@ -65,7 +65,7 @@ public function processNode(Node $node, Scope $scope): array
6565
}
6666
$mode = $modeTypes[0]->getValue();
6767

68-
$defaultType = $scope->getType($node->args[4]->value);
68+
$defaultType = $scope->getType($node->getArgs()[4]->value);
6969

7070
// not an array
7171
if (($mode & 8) !== 8) {

src/Rules/Symfony/UndefinedArgumentRule.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,11 @@ public function processNode(Node $node, Scope $scope): array
6464
if (!$node->name instanceof Node\Identifier || $node->name->name !== 'getArgument') {
6565
return [];
6666
}
67-
if (!isset($node->args[0])) {
67+
if (!isset($node->getArgs()[0])) {
6868
return [];
6969
}
7070

71-
$argType = $scope->getType($node->args[0]->value);
71+
$argType = $scope->getType($node->getArgs()[0]->value);
7272
$argStrings = TypeUtils::getConstantStrings($argType);
7373
if (count($argStrings) !== 1) {
7474
return [];

src/Rules/Symfony/UndefinedOptionRule.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,11 @@ public function processNode(Node $node, Scope $scope): array
6464
if (!$node->name instanceof Node\Identifier || $node->name->name !== 'getOption') {
6565
return [];
6666
}
67-
if (!isset($node->args[0])) {
67+
if (!isset($node->getArgs()[0])) {
6868
return [];
6969
}
7070

71-
$optType = $scope->getType($node->args[0]->value);
71+
$optType = $scope->getType($node->getArgs()[0]->value);
7272
$optStrings = TypeUtils::getConstantStrings($optType);
7373
if (count($optStrings) !== 1) {
7474
return [];

src/Type/Symfony/ArgumentTypeSpecifyingExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ public function isMethodSupported(MethodReflection $methodReflection, MethodCall
3838

3939
public function specifyTypes(MethodReflection $methodReflection, MethodCall $node, Scope $scope, TypeSpecifierContext $context): SpecifiedTypes
4040
{
41-
if (!isset($node->args[0])) {
41+
if (!isset($node->getArgs()[0])) {
4242
return new SpecifiedTypes();
4343
}
44-
$argType = $scope->getType($node->args[0]->value);
44+
$argType = $scope->getType($node->getArgs()[0]->value);
4545
return $this->typeSpecifier->create(
4646
Helper::createMarkerNode($node->var, $argType, $this->printer),
4747
$argType,

src/Type/Symfony/Config/ArrayNodeDefinitionPrototypeDynamicReturnTypeExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ public function getTypeFromMethodCall(
5656
$defaultType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
5757

5858
if ($methodReflection->getName() === 'prototype') {
59-
if (!isset($methodCall->args[0])) {
59+
if (!isset($methodCall->getArgs()[0])) {
6060
return $defaultType;
6161
}
6262

63-
$argStrings = TypeUtils::getConstantStrings($scope->getType($methodCall->args[0]->value));
63+
$argStrings = TypeUtils::getConstantStrings($scope->getType($methodCall->getArgs()[0]->value));
6464
if (count($argStrings) === 1 && isset(self::MAPPING[$argStrings[0]->getValue()])) {
6565
$type = $argStrings[0]->getValue();
6666

src/Type/Symfony/Config/TreeBuilderDynamicReturnTypeExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ public function getTypeFromStaticMethodCall(MethodReflection $methodReflection,
4444

4545
$type = 'array';
4646

47-
if (isset($methodCall->args[1])) {
48-
$argStrings = TypeUtils::getConstantStrings($scope->getType($methodCall->args[1]->value));
47+
if (isset($methodCall->getArgs()[1])) {
48+
$argStrings = TypeUtils::getConstantStrings($scope->getType($methodCall->getArgs()[1]->value));
4949
if (count($argStrings) === 1 && isset(self::MAPPING[$argStrings[0]->getValue()])) {
5050
$type = $argStrings[0]->getValue();
5151
}

src/Type/Symfony/EnvelopeReturnTypeExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ public function getTypeFromMethodCall(
3131
Scope $scope
3232
): Type
3333
{
34-
if (count($methodCall->args) === 0) {
34+
if (count($methodCall->getArgs()) === 0) {
3535
return new ArrayType(new MixedType(), new ArrayType(new MixedType(), new ObjectType('Symfony\Component\Messenger\Stamp\StampInterface')));
3636
}
3737

38-
$argType = $scope->getType($methodCall->args[0]->value);
38+
$argType = $scope->getType($methodCall->getArgs()[0]->value);
3939
if (!$argType instanceof ConstantStringType) {
4040
return new ArrayType(new MixedType(), new ObjectType('Symfony\Component\Messenger\Stamp\StampInterface'));
4141
}

0 commit comments

Comments
 (0)