Add stuff and fix some

Author: Girgias

stubs/dom.stub

@@ -49,7 +49,7 @@ class DOMElement extends DOMNode
 
 	/**
 	 * @readonly
-	 * @var DOMNamedNodeMap<DOMAttr>|null
+	 * @var DOMNamedNodeMap<DOMAttr>
 	 */
 	public $attributes;
 
@@ -67,9 +67,14 @@ class DOMElement extends DOMNode
 	public function getElementsByTagNameNS ($namespaceURI, $localName) {}
 
 	/**
-	 * @phpstan-assert-if-true =DOMNamedNodeMap<DOMAttr> $this->attributes
+	 * @phpstan-assert-if-true non-empty-string $this->getAttribute($qualifiedName)
+	 * @phpstan-assert-if-true DOMAttr|DOMNameSpaceNode $this->getAttributeNode($qualifiedName)
 	 */
 	public function hasAttribute(string $qualifiedName): bool {}
+
+	public function getAttribute(string $qualifiedName): string {}
+
+	public function getAttributeNode(string $qualifiedName): DOMAttr|DOMNameSpaceNode|false {}
 }
 
 /**

tests/PHPStan/Analyser/nsrt/DOMLegacyNamedNodeNap.php

@@ -22,30 +22,27 @@ public function basic_node(DOMNode $node): void {
 
 	public function element_node(DOMElement $element): void
 	{
-		assertType('DOMNamedNodeMap<DOMAttr>|null', $element->attributes);
+		assertType('DOMNamedNodeMap<DOMAttr>', $element->attributes);
 		if ($element->hasAttribute('class')) {
-			assertType('DOMNamedNodeMap<DOMAttr>', $element->attributes);
 			$attribute = $element->getAttributeNode('class');
 			assertType(DOMAttr::class, $attribute);
 			assertType('string', $attribute->value);
 		} else {
-			assertType('DOMNamedNodeMap<DOMAttr>|null', $element->attributes);
+			$attribute = $element->getAttributeNode('class');
+			assertType('false', $attribute);
 		}
 	}
 
 	public function element_node_attribute_fetch_via_attributes_property(DOMElement $element): void
 	{
-		assertType('DOMNamedNodeMap<DOMAttr>|null', $element->attributes);
+		assertType('DOMNamedNodeMap<DOMAttr>', $element->attributes);
 		if ($element->hasAttribute('class')) {
-			assertType('DOMNamedNodeMap<DOMAttr>', $element->attributes);
 			$attribute = $element->attributes->getNamedItem('class');
 			if ($attribute === null) {
 				return;
 			}
 			assertType(DOMAttr::class, $attribute);
 			assertType('string', $attribute->value);
-		} else {
-			assertType('DOMNamedNodeMap<DOMAttr>|null', $element->attributes);
 		}
 	}
 }

tests/PHPStan/Rules/Properties/data/dom-legacy-ext-template-nodes.php

@@ -22,3 +22,12 @@ function element_node_attribute_fetch_via_attributes_property(\DOMElement $eleme
 	}
 	echo $attribute->value;
 }
+
+function element_node_attribute_fetch_via_getAttributeNode(\DOMElement $element): void
+{
+	$attribute = $element->getAttributeNode('class');
+	if ($attribute === null) {
+		return;
+	}
+	echo $attribute->value;
+}