Add rule to check @dataProvider

villfa · villfa · commit 349b03d212df · 2022-12-07T15:05:40.000+01:00
diff --git a/src/Rules/PHPUnit/DataProviderHelper.php b/src/Rules/PHPUnit/DataProviderHelper.php
@@ -87,13 +87,6 @@ public function processDataProvider(
 			))->build();
 		}
 
-		if (!$dataProviderMethodReflection->isStatic()) {
-			$errors[] = RuleErrorBuilder::message(sprintf(
-				'@dataProvider %s related method must be static.',
-				$dataProviderName
-			))->build();
-		}
-
 		return $errors;
 	}
 
diff --git a/tests/Rules/PHPUnit/DataProviderDeclarationRuleTest.php b/tests/Rules/PHPUnit/DataProviderDeclarationRuleTest.php
@@ -27,10 +27,6 @@ public function testRule(): void
 				'@dataProvider providebaz related method is used with incorrect case: provideBaz.',
 				13,
 			],
-			[
-				'@dataProvider provideQux related method must be static.',
-				13,
-			],
 			[
 				'@dataProvider provideQuux related method must be public.',
 				13,

Original file line number	Diff line number	Diff line change
`@@ -87,13 +87,6 @@ public function processDataProvider(`
`87`	`87`	`))->build();`
`88`	`88`	`}`
`89`	`89`
`90`		`- if (!$dataProviderMethodReflection->isStatic()) {`
`91`		`- $errors[] = RuleErrorBuilder::message(sprintf(`
`92`		`- '@dataProvider %s related method must be static.',`
`93`		`- $dataProviderName`
`94`		`- ))->build();`
`95`		`- }`
`96`		`-`
`97`	`90`	`return $errors;`
`98`	`91`	`}`
`99`	`92`