Skip to content

Commit 40f28e4

Browse files
ruudkondrejmirtes
authored andcommitted
Updated coding standard that can run on PHP 7.4
1 parent 17958eb commit 40f28e4

File tree

3 files changed

+19
-5
lines changed

3 files changed

+19
-5
lines changed

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"doctrine/persistence": "<1.3"
1818
},
1919
"require-dev": {
20-
"consistence/coding-standard": "^3.0.1",
20+
"consistence/coding-standard": "^3.10",
2121
"dealerdirect/phpcodesniffer-composer-installer": "^0.7.0",
2222
"doctrine/collections": "^1.0",
2323
"doctrine/common": "^2.7 || ^3.0",
@@ -31,7 +31,7 @@
3131
"phpstan/phpstan-strict-rules": "^0.12",
3232
"phpunit/phpunit": "^7.0",
3333
"ramsey/uuid-doctrine": "^1.5.0",
34-
"slevomat/coding-standard": "^4.5.2"
34+
"slevomat/coding-standard": "^6.4"
3535
},
3636
"config": {
3737
"platform": {

phpcs.xml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<property name="newlinesCountBetweenOpenTagAndDeclare" value="0"/>
2020
</properties>
2121
</rule>
22-
<rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration">
22+
<rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint">
2323
<properties>
2424
<property name="usefulAnnotations" type="array" value="
2525
@dataProvider,
@@ -30,8 +30,20 @@
3030
<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingTraversableParameterTypeHintSpecification"/>
3131
<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingTraversableReturnTypeHintSpecification"/>
3232
</rule>
33+
<rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint">
34+
<properties>
35+
<property name="enableNativeTypeHint" value="false"/>
36+
</properties>
37+
<exclude name="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingTraversableTypeHintSpecification"/>
38+
</rule>
39+
<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint">
40+
<properties>
41+
<property name="enableObjectTypeHint" value="false"/>
42+
</properties>
43+
<exclude name="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingTraversableTypeHintSpecification"/>
44+
</rule>
3345
<rule ref="SlevomatCodingStandard.ControlStructures.AssignmentInCondition"/>
34-
<rule ref="SlevomatCodingStandard.ControlStructures.DisallowEqualOperators"/>
46+
<rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators"/>
3547
<rule ref="SlevomatCodingStandard.ControlStructures.EarlyExit"/>
3648
<rule ref="SlevomatCodingStandard.Classes.SuperfluousAbstractClassNaming"/>
3749
<rule ref="SlevomatCodingStandard.Classes.SuperfluousInterfaceNaming"/>

src/Type/Doctrine/ObjectMetadataResolver.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ private function getResolvedRepositoryClass(): string
7878
$objectManager = $this->getObjectManager();
7979
if ($this->repositoryClass !== null) {
8080
return $this->resolvedRepositoryClass = $this->repositoryClass;
81-
} elseif ($objectManager !== null && get_class($objectManager) === 'Doctrine\ODM\MongoDB\DocumentManager') {
81+
}
82+
83+
if ($objectManager !== null && get_class($objectManager) === 'Doctrine\ODM\MongoDB\DocumentManager') {
8284
return $this->resolvedRepositoryClass = 'Doctrine\ODM\MongoDB\Repository\DocumentRepository';
8385
}
8486

0 commit comments

Comments
 (0)