Skip to content

Commit d8fc420

Browse files
committed
fix: removeByIdInFlatData
1 parent fffcaa2 commit d8fc420

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

lib/HeTree.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1002,6 +1002,7 @@ export function removeByIdInFlatData<T extends Record<Id, any>>(
10021002
}
10031003
} else {
10041004
endIndex = treeIndex
1005+
break
10051006
}
10061007
}
10071008
if (endIndex === -1) {

src/test/flatData.test.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,14 +204,21 @@ test("removeByIdInFlatData", () => {
204204
//
205205
cur = [...data];
206206
removeByIdInFlatData(cur, 2);
207-
expect(cur.length).toBe(2);
207+
expect(cur.length).toBe(4);
208208
//
209209
cur = [...data];
210-
removeByIdInFlatData(cur, 5);
211-
expect(cur.length).toBe(3);
210+
console.log("if remove id 5", removeByIdInFlatData(cur, 5));
211+
expect(cur.length).toBe(7);
212+
//
213+
cur = createData("key");
214+
let removed = removeByIdInFlatData(cur, 10, { idKey: "key" });
215+
expect(removed.length).toBe(1);
216+
expect(removed[0].key).toBe(10);
217+
expect(cur.length).toBe(data.length - 1);
212218
});
213219

214220
function createData(id = "id", parent_id = "parent_id") {
221+
// size 9
215222
return [
216223
{
217224
[id]: 1,

0 commit comments

Comments
 (0)