Fix issues found by psalm

Author: discordier

psalm.xml

@@ -11,6 +11,34 @@
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
 >
     <projectFiles>
+        <directory name="config" />
         <directory name="src" />
+        <ignoreFiles>
+            <file name="config/bootstrap.php" />
+        </ignoreFiles>
     </projectFiles>
+    <issueHandlers>
+        <PossiblyUnusedMethod>
+            <errorLevel type="suppress">
+                <!-- Only called via dependency injection -->
+                <referencedMethod name="Phpcq\RepositoryBuilder\Api\GithubClient::__construct"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\Command\RebuildCommand::__construct"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\Kernel::configureContainer"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\SourceProvider\Plugin\Github\RepositoryFactory::__construct"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\SourceProvider\Tool\Github\TagProviderRepositoryFactory::__construct"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\SourceProvider\Tool\PharIo\RepositoryFactory::__construct"/>
+
+                <!-- Only called via from tests for now - will be used when adding more loaders? -->
+                <referencedMethod name="Phpcq\RepositoryBuilder\SourceProvider\LoaderContext::getPluginConstraint"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\SourceProvider\LoaderContext::getPluginName"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\SourceProvider\Plugin\Github\JsonEntry::getRepository"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\SourceProvider\Plugin\Github\JsonEntry::getTagName"/>
+
+                <!-- Writing of XML files currently not needed in this project. -->
+                <referencedMethod name="Phpcq\RepositoryBuilder\File\XmlFile::createElement"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\File\XmlFile::addElement"/>
+                <referencedMethod name="Phpcq\RepositoryBuilder\File\XmlFile::save"/>
+            </errorLevel>
+        </PossiblyUnusedMethod>
+    </issueHandlers>
 </psalm>

src/SourceProvider/Plugin/Github/JsonEntry.php

@@ -143,7 +143,8 @@ public function getContents(): array
     private function makeAbsolute(string $uri): string
     {
         $scheme = parse_url($uri, PHP_URL_SCHEME);
-        if (empty($scheme)) {
+        assert((null === $scheme) || is_string($scheme));
+        if ((null === $scheme) || ('' === $scheme)) {
             // Must be relative to repository then.
             return $this->githubClient->fileUri($this->repository, $this->tagName, $uri);
         }

src/SourceProvider/Plugin/Github/Repository.php

@@ -95,7 +95,7 @@ private function handleJsonFile(JsonEntry $jsonEntry): void
     private function loadPluginRequirements(?array $requirements): PluginRequirements
     {
         $result = new PluginRequirements();
-        if (empty($requirements)) {
+        if ([] === $requirements || null === $requirements) {
             return $result;
         }
 
@@ -129,7 +129,8 @@ private function loadPluginRequirements(?array $requirements): PluginRequirement
     private function createHash(string $absoluteUriPlugin): PluginHash
     {
         $scheme = parse_url($absoluteUriPlugin, PHP_URL_SCHEME);
-        if (!empty($scheme) && $scheme !== 'file') {
+        assert((null === $scheme) || is_string($scheme));
+        if (null !== $scheme && $scheme !== 'file') {
             try {
                 return PluginHash::createForString(
                     $this->httpClient->request('GET', $absoluteUriPlugin)->getContent()

src/SourceProvider/PluginProviderRepository.php

@@ -100,7 +100,7 @@ public function getPluginIterator(): Generator
     private function loadPluginRequirements(?array $requirements): PluginRequirements
     {
         $result = new PluginRequirements();
-        if (empty($requirements)) {
+        if ([] === $requirements || null === $requirements) {
             return $result;
         }