Enable psalm for phpcs.php

Author: dmolineus

psalm.xml

@@ -7,4 +7,7 @@
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
 >
+    <projectFiles>
+        <file name="src/phpcs.php"/>
+    </projectFiles>
 </psalm>

src/phpcs.php

@@ -205,7 +205,7 @@ private function createHelpParser(): OutputInterface
             /** @var array<string,string> */
             private $descriptions = [];
 
-            /** @var array<string,array{description:string, short?: bool, paramName?: string|null}> */
+            /** @var array<string,array{description:string, short?: bool, paramName?: string|null, keyValue?: bool}> */
             private $options = [];
 
             /** @var array<string,string> */
@@ -279,7 +279,8 @@ private function describe(ConsoleApplicationBuilderInterface $application): void
                         $definition->withShortcutOnly();
                     }
 
-                    if ($config['paramName'] ?? null) {
+                    if (($config['paramName'] ?? null) !== null) {
+                        /** @psalm-suppress PossiblyUndefinedArrayOffset */
                         $definition->withRequiredValue($config['paramName']);
                     }
 
@@ -352,7 +353,6 @@ private function parseShortOptionDescriptions(string $help): void
                     }
 
                     if (null !== $currentName) {
-                        assert(is_string($currentName));
                         $this->options[$currentName]['short'] = true;
                         $this->options[$currentName]['description'] = $currentDescription;
                     }
@@ -362,7 +362,6 @@ private function parseShortOptionDescriptions(string $help): void
                 }
 
                 if ($currentName !== null) {
-                    assert(is_string($currentName));
                     $this->options[$currentName]['short'] = true;
                     $this->options[$currentName]['description'] = $currentDescription;
                 }
@@ -376,8 +375,11 @@ private function parseOptionDescriptions(string $help): void
 
                 foreach ($lines as $line) {
                     preg_match('#^\s+(--[a-z-]*)?\s+(.*)$#', $line, $matches);
+                    if ($matches === []) {
+                        continue;
+                    }
 
-                    if ($matches[1] === '' || $matches[1] === null) {
+                    if ($matches[1] === '') {
                         $currentDescription .= ' ' . trim($matches[2]);
                         continue;
                     }