Skip to content

Commit f7a6c30

Browse files
committed
Fix some bugs
1 parent be9c6f7 commit f7a6c30

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ Code links
3838

3939
To show us all features are included, you need to indicate where each feature is coded.
4040

41-
[./codeLink.sh](documentation/codeLink.sh) helps you to tell us.
41+
[./codeLink.sh](documentation/codeLink.md) helps you to tell us.
4242

4343
Everything is done
4444
-
4545

46-
When [./codeValidation.sh](documentation/codeValidation.md) and [./codeLink.sh](documentation/codeLink.md) say it's good,
46+
When [./codeValidation.sh](documentation/codeValidation.md) and [./codeLink.md](documentation/codeLink.md) say it's good,
4747
you can tell us to launch benchmarks with [contact form](http://www.phpbenchmarks.com/en/contact).
4848

4949
Thank you!

codeLink.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ source validation/configurationValidation.sh
66
function isValidUrl {
77
local url=$1
88

9-
if [ "$url" == "" ] || ([ "${url:0:7}" != "http://" ] && [ "$ {$url0:0:8}" != "https://" ]); then
9+
if [ "${url:0:8}" != "https://" ]; then
1010
return 1
1111
fi
1212

documentation/codeLink.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,18 @@ Configure code links
33

44
To prove all features are coded, you need to configure `$codeLinks` in `.phpbenchmarks/codeLink.sh`.
55

6+
`$codeLinks` contains links to your code, on `common` repository, for each benchmark feature.
7+
<br>
8+
Example for Symfony 4.0 Hello world:
9+
```bash
10+
#!/usr/bin/env bash
11+
12+
declare -A codeLinks=(
13+
[controller]="https://github.com/phpbenchmarks/symfony-common/blob/symfony_4_hello-world_prepare/Controller/HelloWorldController.php"
14+
[route]="https://github.com/phpbenchmarks/symfony-common/blob/symfony_4_hello-world_prepare/Resources/config/routing.yml"
15+
)
16+
```
17+
618
To do it easily, you can use `./codeLink.sh`.
719

820
./codeLink.sh

0 commit comments

Comments
 (0)