Some minor fixes

Author: steevanb

src/Command/BenchmarkValidateCommand.php

@@ -22,13 +22,7 @@ protected function configure()
 
     protected function doExecute(): parent
     {
-        $this
-            ->runCommand('validate:configuration:component')
-            ->runCommand('validate:branch:name')
-            ->runCommand('validate:composer:json')
-            ->runCommand('validate:composer:lock')
-            ->runCommand('validate:configuration:initBenchmark')
-            ->runCommand('validate:configuration:vhost');
+        $this->runCommand('validate:all');
 
         foreach (ComponentConfiguration::getEnabledPhpVersions() as $phpVersion) {
             $this->validateForPhpVersion($phpVersion);

src/Command/Configure/ConfigureComponentSourceCodeUrlsCommand.php

@@ -6,7 +6,7 @@
 
 use AbstractComponentConfiguration\AbstractComponentConfiguration;
 use App\{
-    Command\Validate\ValidateConfigurationComponentCommand,
+    Command\Validate\ValidateConfigurationComponentSourceCodeUrlsCommand,
     ComponentConfiguration\ComponentConfiguration
 };
 use Symfony\Component\Validator\ConstraintViolationInterface;
@@ -34,8 +34,7 @@ protected function doExecute(): parent
         if ($this->skipSourceCodeUrls() === false) {
             $this
                 ->title('Configuration of AbstractComponentConfiguration::getSourceCodeUrls()')
-                ->defineSourceCodeUrls()
-                ->runCommand('validate:configuration:component:sourceCodeUrls');
+                ->defineSourceCodeUrls();
         }
 
         return $this;
@@ -88,7 +87,7 @@ protected function getSourceCodeUrls(): array
         ];
 
         foreach ($return as &$url) {
-            $violations = ValidateConfigurationComponentCommand::validateSourCodeUrl($url['url']);
+            $violations = ValidateConfigurationComponentSourceCodeUrlsCommand::validateSourCodeUrl($url['url']);
             $showWarning = false;
             do {
                 if (count($violations) > 0) {
@@ -105,7 +104,11 @@ protected function getSourceCodeUrls(): array
                 }
 
                 $showWarning = true;
-            } while (count($violations = ValidateConfigurationComponentCommand::validateSourCodeUrl($url['url'])) > 0);
+            } while (
+                count(
+                    $violations = ValidateConfigurationComponentSourceCodeUrlsCommand::validateSourCodeUrl($url['url'])
+                ) > 0
+            );
         }
 
         return $return;

src/Command/Validate/ValidateAllCommand.php

@@ -24,6 +24,7 @@ protected function doExecute(): parent
             ->runCommand('validate:composer:json')
             ->runCommand('validate:composer:lock')
             ->runCommand('validate:configuration:component')
+            ->runCommand('validate:configuration:component:sourceCodeUrls')
             ->runCommand('validate:configuration:initBenchmark')
             ->runCommand('validate:configuration:responseBody')
             ->runCommand('validate:configuration:vhost');

src/Command/Validate/ValidateComposerLockFilesCommand.php

@@ -53,7 +53,7 @@ private function validateEnabledPhpVersions(): self
             $lockFile = 'composer.lock.php' . $phpVersion;
             $lockPath = $this->getInstallationPath() . '/' . $lockFile;
             if (is_readable($lockPath) === false) {
-                $this->error('File does not exist.');
+                $this->error('File does not exist. Call "phpbench composer:update" to create it.');
             }
 
             try {

src/Command/Validate/ValidateConfigurationComponentCommand.php

@@ -11,28 +11,9 @@
     ComponentConfiguration\ComponentConfiguration,
     PhpVersion\PhpVersion
 };
-use Symfony\Component\Validator\{
-    Constraints\NotBlank,
-    Constraints\Type,
-    Constraints\Url,
-    ConstraintViolationListInterface,
-    Validation
-};
 
 class ValidateConfigurationComponentCommand extends AbstractCommand
 {
-    public static function validateSourCodeUrl($url): ConstraintViolationListInterface
-    {
-        return Validation::createValidator()->validate(
-            $url,
-            [
-                new NotBlank(),
-                new Type(['type' => 'string']),
-                new Url()
-            ]
-        );
-    }
-
     protected function configure()
     {
         parent::configure();