Skip to content

Commit b007d67

Browse files
committed
performance (5)
1 parent 499e5dd commit b007d67

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

Ajax/bootstrap/html/HtmlTabs.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ protected function addTab_($tab, $index=null) {
4040
}
4141

4242
public function setActive($index){
43-
for ($i=0;$i<sizeof($this->tabs);$i++){
43+
$size=\sizeof($this->tabs);
44+
for ($i=0;$i<$size;$i++){
4445
$this->tabs[$i]->setActive($i==$index);
4546
}
4647
}
@@ -159,7 +160,7 @@ public function fadeEffect() {
159160
}
160161
}
161162
}
162-
163+
163164
public function on($event, $jsCode,$stopPropagation=false,$preventDefault=false){
164165
foreach ($this->tabs as $tab){
165166
$tab->on($event,$jsCode,$stopPropagation,$preventDefault);

Ajax/semantic/html/collections/HtmlGrid.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,13 +286,14 @@ protected function createItem($value) {
286286
*/
287287
public function setValues($values, $force=true) {
288288
$count=$this->count();
289+
$valuesSize=\sizeof($values);
289290
if ($this->_createCols === false || $force === true) {
290-
for($i=$count; $i < \sizeof($values); $i++) {
291+
for($i=$count; $i < $valuesSize; $i++) {
291292
$colSize=\sizeof($values[$i]);
292293
$this->addItem(new HtmlGridRow($this->identifier . "-row-" . ($this->count() + 1), $colSize, $this->_colSizing, $this->_implicitRows));
293294
}
294295
}
295-
$count=\min(array ($this->count(),\sizeof($values) ));
296+
$count=\min(array ($this->count(),$valuesSize ));
296297
for($i=0; $i < $count; $i++) {
297298
$this->content[$i]->setValues($values[$i], $this->_createCols === false);
298299
}

Ajax/semantic/html/content/HtmlGridRow.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,13 @@ public function setColor($color){
101101

102102
public function setValues($values,$force=false){
103103
$count=$this->count();
104+
$valuesSize=\sizeof($values);
104105
if($force===true){
105-
for($i=$count;$i<\sizeof($values);$i++){
106+
for($i=$count;$i<$valuesSize;$i++){
106107
$this->addItem(new HtmlGridCol($this->identifier."-col-".($this->count()+1),null));
107108
}
108109
}
109-
$count=\min(array($this->count(),\sizeof($values)));
110+
$count=\min(array($this->count(),$valuesSize));
110111
for($i=0;$i<$count;$i++){
111112
$this->content[$i]->setValue($values[$i]);
112113
}

Ajax/semantic/html/modules/HtmlTab.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ public function setTabContent($index,$content){
7979
* @return \Ajax\semantic\html\modules\HtmlTab
8080
*/
8181
public function setTabsContent($contents){
82-
for($i=0;$i<\sizeof($contents);$i++){
82+
$size=\sizeof($contents);
83+
for($i=0;$i<$size;$i++){
8384
$this->setTabContent($i, $contents[$i]);
8485
}
8586
return $this;
@@ -204,14 +205,16 @@ public function getTab($index){
204205
* @return \Ajax\semantic\html\modules\HtmlTab
205206
*/
206207
public function setMenu($menu){
207-
for($i=0;$i<\sizeof($this->content);$i++){
208+
$contentSize=\sizeof($this->content);
209+
for($i=0;$i<$contentSize;$i++){
208210
if($menu->getItem($i)!==NULL){
209211
if(isset($this->content[$i])){
210212
$menu->getItem($i)->addToProperty("data-tab",$this->content[$i]->getProperty("data-tab"));
211213
}
212214
}
213215
}
214-
for($i=0;$i<$menu->count();$i++){
216+
$menuSize=$menu->count();
217+
for($i=0;$i<$menuSize;$i++){
215218
$menu->getItem($i)->removeProperty("href");
216219
if(isset($this->content[$i])===false){
217220
$this->content[$i]=$this->createSegment($i, "New content", $menu->getItem($i)->getIdentifier());

0 commit comments

Comments
 (0)