Skip to content

Commit 0b37738

Browse files
committed
clean preventDefault
1 parent 24138a2 commit 0b37738

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

Ajax/Jquery.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,10 +206,10 @@ public function _add_event($element, $js, $event, $preventDefault=false, $stopPr
206206
$js=implode("\n\t\t", $js);
207207
}
208208
if ($preventDefault===true) {
209-
$js="event.preventDefault();\n".$js;
209+
$js=Javascript::$preventDefault.$js;
210210
}
211211
if ($stopPropagation===true) {
212-
$js="event.stopPropagation();\n".$js;
212+
$js=Javascript::$stopPropagation.$js;
213213
}
214214
if (array_search($event, $this->jquery_events)===false)
215215
$event="\n\t$(".Javascript::prep_element($element).").bind('{$event}',function(event){\n\t\t{$js}\n\t});\n";

Ajax/common/html/traits/BaseHtmlEventsTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ trait BaseHtmlEventsTrait{
2424
*/
2525
public function addEvent($event, $jsCode, $stopPropagation=false, $preventDefault=false) {
2626
if ($stopPropagation === true) {
27-
$jsCode="event.stopPropagation();" . $jsCode;
27+
$jsCode=Javascript::$stopPropagation . $jsCode;
2828
}
2929
if ($preventDefault === true) {
30-
$jsCode="event.preventDefault();" . $jsCode;
30+
$jsCode=Javascript::$preventDefault . $jsCode;
3131
}
3232
return $this->_addEvent($event, $jsCode);
3333
}

Ajax/semantic/html/collections/form/traits/FormTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public function onValid($jsCode){
116116
*/
117117
public function onSuccess($jsCode){
118118
$form=$this->getForm();
119-
$form->addValidationParam("onSuccess", "%function(evt,fields){".$jsCode."}%");
119+
$form->addValidationParam("onSuccess", "%function(event,fields){console.log(fields);".$jsCode."}%");
120120
return $form;
121121
}
122122
}

Ajax/service/AjaxCall.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ public function compile(JsUtils $js=null) {
2727
$hasLoader=true;
2828
extract($this->parameters);
2929
if ($preventDefault===true) {
30-
$result.="\nevent.preventDefault();\n";
30+
$result.=Javascript::$preventDefault;
3131
}
3232
if ($stopPropagation===true) {
33-
$result.="event.stopPropagation();\n";
33+
$result.=Javascript::$stopPropagation;
3434
}
3535
switch($this->method) {
3636
case "get":

Ajax/service/Javascript.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
namespace Ajax\service;
44

55
class Javascript {
6+
public static $preventDefault="\nif(event && event.preventDefault) event.preventDefault();\n";
7+
public static $stopPropagation="\nif(event && event.stopPropagation) event.stopPropagation();\n";
8+
69
public static function containsCode($expression){
710
return strrpos($expression, 'this')!==false||strrpos($expression, 'event')!==false||strrpos($expression, 'self')!==false;
811
}

0 commit comments

Comments
 (0)