Visibility filters do not work properly

In issue phpDocumentor/phpDocumentor#573 @ferjul17 mentioned
that the visibility filters do not function properly.

During research we discovered that the logic was faulty and that bootstrap sets the 'active'
class after this event is called. With this commit we fix this behaviour and it works as
expected.

Author: mvriel

js/template.js

@@ -46,18 +46,37 @@ function initializeContents()
         .find('i').click(function(){ $(this).parent().click(); });
 
     // set the events for the visibility buttons and enable by default.
-    $('.visibility button.public').click(function(){
-        $('.element.public,.side-nav li.public').toggle($(this).hasClass('active'));
-    }).click();
-    $('.visibility button.protected').click(function(){
-        $('.element.protected,.side-nav li.protected').toggle($(this).hasClass('active'));
-    }).click();
-    $('.visibility button.private').click(function(){
-        $('.element.private,.side-nav li.private').toggle($(this).hasClass('active'));
-    }).click();
-    $('.visibility button.inherited').click(function(){
-        $('.element.inherited,.side-nav li.inherited').toggle($(this).hasClass('active'));
-    }).click();
+    function toggleVisibility(event)
+    {
+        // because the active class is toggled _after_ this event we toggle it for the duration of this event. This
+        // will make the next piece of code generic
+        if (event) {
+            $(this).toggleClass('active');
+        }
+
+        $('.element.public,.side-nav li.public').toggle($('.visibility button.public').hasClass('active'));
+        $('.element.protected,.side-nav li.protected').toggle($('.visibility button.protected').hasClass('active'));
+        $('.element.private,.side-nav li.private').toggle($('.visibility button.private').hasClass('active'));
+        $('.element.public.inherited,.side-nav li.public.inherited').toggle(
+            $('.visibility button.public').hasClass('active') && $('.visibility button.inherited').hasClass('active')
+        );
+        $('.element.protected.inherited,.side-nav li.protected.inherited').toggle(
+            $('.visibility button.protected').hasClass('active') && $('.visibility button.inherited').hasClass('active')
+        );
+        $('.element.private.inherited,.side-nav li.private.inherited').toggle(
+            $('.visibility button.private').hasClass('active') && $('.visibility button.inherited').hasClass('active')
+        );
+
+        // and untoggle the active class again so that bootstrap's default handling keeps working
+        if (event) {
+            $(this).toggleClass('active');
+        }
+    }
+    $('.visibility button.public').on("click", toggleVisibility);
+    $('.visibility button.protected').on("click", toggleVisibility);
+    $('.visibility button.private').on("click", toggleVisibility);
+    $('.visibility button.inherited').on("click", toggleVisibility);
+    toggleVisibility();
 
     $('.type-filter button.critical').click(function() {
         packageContentDivs = $('.package-contents');