Improvements to code

Author: jaapio

src/DocBlock/StandardTagFactory.php

@@ -229,7 +229,7 @@ private function createTag(string $body, string $name, TypeContext $context) : T
             $callable = [$handlerClassName, 'create'];
             return call_user_func_array($callable, $arguments);
         } catch (InvalidArgumentException $e) {
-            return InvalidTag::create($body, $name, $e);
+            return InvalidTag::create($body, $name)->withError($e);
         }
     }
 

src/DocBlock/Tags/InvalidTag.php

@@ -6,7 +6,6 @@
 
 use phpDocumentor\Reflection\DocBlock\Tag;
 use Throwable;
-use Webmozart\Assert\Assert;
 
 /**
  * This class represents an exception during the tag creation
@@ -26,17 +25,16 @@ final class InvalidTag implements Tag
     /** @var string */
     private $body;
 
-    /** @var Throwable */
+    /** @var Throwable|null */
     private $throwable;
 
-    private function __construct(string $name, string $body, Throwable $throwable)
+    private function __construct(string $name, string $body)
     {
-        $this->name      = $name;
-        $this->body      = $body;
-        $this->throwable = $throwable;
+        $this->name = $name;
+        $this->body = $body;
     }
 
-    public function getException() : Throwable
+    public function getException() : ?Throwable
     {
         return $this->throwable;
     }
@@ -47,13 +45,21 @@ public function getName() : string
     }
 
     /**
+     * @return self
+     *
      * @inheritDoc
      */
-    public static function create(string $body, string $name = '', ?Throwable $exception = null)
+    public static function create(string $body, string $name = '')
     {
-        Assert::notNull($exception);
+        return new self($name, $body);
+    }
+
+    public function withError(Throwable $exception) : self
+    {
+        $tag            = new self($this->name, $this->body);
+        $tag->throwable = $exception;
 
-        return new self($name, $body, $exception);
+        return $tag;
     }
 
     public function render(?Formatter $formatter = null) : string

tests/unit/DocBlock/StandardTagFactoryTest.php

@@ -332,7 +332,7 @@ public function testReturnTagIsMappedCorrectly() : void
         $this->assertSame('return', $tag->getName());
     }
 
-    public function testInvalidTagIsReturnedOnFailure()
+    public function testInvalidTagIsReturnedOnFailure() : void
     {
         $tagFactory = new StandardTagFactory(m::mock(FqsenResolver::class));
 

tests/unit/DocBlock/Tags/InvalidTagTest.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+namespace phpDocumentor\Reflection\DocBlock\Tags;
+
+use Exception;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @coversDefaultClass \phpDocumentor\Reflection\DocBlock\Tags\InvalidTag
+ * @covers ::<private>
+ * @covers ::getName
+ * @covers ::render
+ * @covers ::getException
+ * @covers ::create
+ */
+final class InvalidTagTest extends TestCase
+{
+    public function testCreationWithoutError() : void
+    {
+        $tag = InvalidTag::create('Body', 'name');
+
+        self::assertSame('name', $tag->getName());
+        self::assertSame('@name Body', $tag->render());
+        self::assertNull($tag->getException());
+    }
+
+    /**
+     * @covers ::withError
+     */
+    public function testCreationWithError() : void
+    {
+        $exception = new Exception();
+        $tag       = InvalidTag::create('Body', 'name')->withError($exception);
+
+        self::assertSame('name', $tag->getName());
+        self::assertSame('@name Body', $tag->render());
+        self::assertSame($exception, $tag->getException());
+    }
+}