Skip to content

Commit b013ecf

Browse files
committed
Fix build URLs for 8.5
1 parent 6782029 commit b013ecf

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

extension/BuildPhpExtension/private/Get-PhpBuildDetails.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function Get-PhpBuildDetails {
1515
process {
1616
if($Config.php_version -eq 'master' -or $Config.php_version -eq '8.5') {
1717
$baseUrl = $fallbackBaseUrl = "https://github.com/shivammathur/php-builder-windows/releases/download/master"
18-
$PhpSemver = $PhpVersion
18+
$PhpSemver = 'master'
1919
} else {
2020
foreach($releaseState in @("releases", "qa")) {
2121
$baseUrl = "https://downloads.php.net/~windows/$releaseState"

php/BuildPhp/private/Get-PhpBuild.ps1

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,17 @@ function Get-PhpBuild {
4040
throw "PHP version $PhpVersion is not supported."
4141
}
4242
}
43+
$versionInUrl = $PhpVersion
4344
if($PhpVersion -eq 'master' -or $PhpVersion -eq '8.5') {
4445
$fallbackBaseUrl = $baseUrl = "https://github.com/shivammathur/php-builder-windows/releases/download/master"
46+
$versionInUrl = "master"
4547
} else {
4648
$releaseState = if ($PhpVersion -match "[a-z]") {"qa"} else {"releases"}
4749
$baseUrl = "https://downloads.php.net/~windows/$releaseState"
4850
$fallbackBaseUrl = "https://downloads.php.net/~windows/$releaseState/archives"
4951
}
5052
$tsPart = if ($Ts -eq "nts") {"nts-Win32"} else {"Win32"}
51-
$binZipFile = "php-$PhpVersion-$tsPart-$VsVersion-$Arch.zip"
53+
$binZipFile = "php-$versionInUrl-$tsPart-$VsVersion-$Arch.zip"
5254
$binUrl = "$baseUrl/$binZipFile"
5355
$fallBackUrl = "$fallbackBaseUrl/$binZipFile"
5456

php/BuildPhp/private/Get-PhpTestPack.ps1

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,16 @@ function Get-PhpTestPack {
2222
process {
2323
Add-Type -Assembly "System.IO.Compression.Filesystem"
2424

25+
$versionInUrl = $PhpVersion
2526
if($PhpVersion -eq 'master' -or $PhpVersion -eq '8.5') {
2627
$fallbackBaseUrl = $baseUrl = "https://github.com/shivammathur/php-builder-windows/releases/download/master"
28+
$versionInUrl = "master"
2729
} else {
2830
$releaseState = if ($PhpVersion -match "[a-z]") {"qa"} else {"releases"}
2931
$baseUrl = "https://downloads.php.net/~windows/$releaseState"
3032
$fallbackBaseUrl = "https://downloads.php.net/~windows/$releaseState/archives"
3133
}
32-
$testZipFile = "php-test-pack-$PhpVersion.zip"
34+
$testZipFile = "php-test-pack-$versionInUrl.zip"
3335
$testUrl = "$baseUrl/$testZipFile"
3436
$fallBackUrl = "$fallbackBaseUrl/$testZipFile"
3537

0 commit comments

Comments
 (0)