Remove null byte from anonymous class name

[jorgsowa]

Description

I suggest removing the null byte from an anonymous class name, which can be visible in stack traces. Precisely, it's about this line: https://github.com/php/php-src/blob/master/Zend/zend_compile.c#L9024

It causes problems in observability and testing, and requires workarounds. Example I found:

• Multiply/paratest@e8f9cd4
• Consider stripping null byte in frame name brendangregg/FlameGraph#280
• Remove NULL byte from class names, which cause problems when using phpdbg nette/tester#450

The change is trivial, but it would be BC break.

[ndossche]

I solved at least some printing related issues (including one in phpdbg) regarding nul bytes in php errors/warnings. If you have a more concrete example of where this is still not done, please share it; otherwise this seems like a needless BC break to me.

[jorgsowa]

It's in the exception stack trace.

class Test {
}

try {
    $test = new class() extends Test {
        public function run()
        {
            throw new Exception();
        }
    };
    $test->run();
} catch (Throwable $e) {
    var_dump($e->getTrace());
}

And the result:

array(1) {
  [0]=>
  array(6) {
    ["file"]=>
    string(92) "/path/scratch_2.php"
    ["line"]=>
    int(13)
    ["function"]=>
    string(3) "run"
    ["class"]=>
    string(111) "Test@anonymous�/path/scratch_2.php:7$0"
    ["type"]=>
    string(2) "->"
    ["args"]=>
    array(0) {
    }
  }
}

[ndossche]

Indeed it's in the backtrace, but it's printed out properly.

[github-actions]

No feedback was provided. The issue is being suspended because we assume that you are no longer experiencing the problem. If this is not the case and you are able to provide the information that was requested earlier, please do so. Thank you.