Expose tentative return types to userland

Author: kocsismate

Zend/tests/type_declarations/variance/internal_parent/compatible_return_type.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Test that no notice is emitted when the return type/value of the overriding method is compatible with the optional return type/value of the overridden method
+Test that no notice is emitted when the return type/value of the overriding method is compatible with the tentative return type/value of the overridden method
 --FILE--
 <?php
 class MyDateTimeZone extends DateTimeZone

Zend/tests/type_declarations/variance/internal_parent/incompatible_return_type.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Test that a notice is emitted when the return type/value of the overriding method is incompatible with the optional return type/value of the overridden method
+Test that a notice is emitted when the return type/value of the overriding method is incompatible with the tentative return type/value of the overridden method
 --FILE--
 <?php
 class MyDateTimeZone extends DateTimeZone

Zend/tests/type_declarations/variance/internal_parent/missing_return_type.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Test that a notice is emitted when the optional return type of the overridden method is omitted
+Test that a notice is emitted when the tentative return type of the overridden method is omitted
 --FILE--
 <?php
 class MyDateTimeZone extends DateTimeZone

Zend/tests/type_declarations/variance/optional_return_type/incompatible_return_type.phpt

@@ -0,0 +1,28 @@
+--TEST--
+Test that a notice is emitted when the return type/value of the overriding method is incompatible with the tentative return type/value of the overridden method
+--FILE--
+<?php
+class Foo
+{
+    #[TentativeReturnType]
+    public function x(): string|false
+    {
+        return "x";
+    }
+}
+
+class Bar extends Foo
+{
+    public function x(): array
+    {
+        return [];
+    }
+}
+
+$bar = new Bar();
+var_dump($bar->x());
+?>
+--EXPECTF--
+Strict Standards: Declaration of Bar::x(): array should be compatible with Foo::x(): string|false in %s on line %d
+array(0) {
+}

Zend/tests/type_declarations/variance/optional_return_type/incompatible_return_type2.phpt

@@ -0,0 +1,28 @@
+--TEST--
+Test that a notice is emitted when the return type/value of the overriding method is incompatible with the tentative return type/value of the overridden method
+--FILE--
+<?php
+class Foo
+{
+    #[TentativeReturnType]
+    public function x(): string|false
+    {
+        return "x";
+    }
+}
+
+class Bar extends Foo
+{
+    public function x()
+    {
+        return [];
+    }
+}
+
+$bar = new Bar();
+var_dump($bar->x());
+?>
+--EXPECTF--
+Strict Standards: Declaration of Bar::x() should be compatible with Foo::x(): string|false in %s on line %d
+array(0) {
+}

Zend/tests/type_declarations/variance/optional_return_type/incompatible_return_type3.phpt

@@ -0,0 +1,34 @@
+--TEST--
+Test that the TentativeReturnType attribute is not inherited
+--FILE--
+<?php
+class Foo
+{
+    #[TentativeReturnType]
+    public function x(): string|false
+    {
+        return "x";
+    }
+}
+
+class Bar extends Foo
+{
+    public function x(): array
+    {
+        return [];
+    }
+}
+
+class Baz extends Bar
+{
+    public function x()
+    {
+        return [];
+    }
+}
+
+?>
+--EXPECTF--
+Strict Standards: Declaration of Bar::x(): array should be compatible with Foo::x(): string|false in %s on line %d
+
+Fatal error: Declaration of Baz::x() must be compatible with Bar::x(): array in %s on line %d

Zend/tests/type_declarations/variance/optional_return_type/incompatible_return_type4.phpt

@@ -0,0 +1,24 @@
+--TEST--
+Test that the TentativeReturnType attribute doesn't suppress type errors
+--FILE--
+<?php
+class Foo
+{
+    public function x(): string
+    {
+        return "x";
+    }
+}
+
+class Bar extends Foo
+{
+    #[TentativeReturnType]
+    public function x(): array
+    {
+        return [];
+    }
+}
+
+?>
+--EXPECTF--
+Fatal error: Declaration of Bar::x(): array must be compatible with Foo::x(): string in %s on line %d

Zend/tests/type_declarations/variance/optional_return_type/missing_return_type.phpt

@@ -0,0 +1,17 @@
+--TEST--
+Test that a compile error is emitted if the TentativeReturnType attribute is used when the method doesn't have a return type
+--FILE--
+<?php
+
+class Foo
+{
+    #[TentativeReturnType]
+    public function x()
+    {
+        return "x";
+    }
+}
+
+?>
+--EXPECTF--
+Fatal error: TentativeReturnType attribute cannot be used when a method doesn't have any return type in %s on line %d

Zend/tests/type_declarations/variance/optional_return_type/suppressed_incompatible_return_type.phpt

@@ -0,0 +1,28 @@
+--TEST--
+Test that the notice can be suppressed when the return type/value of the overriding method is incompatible with the tentative return type/value of the overridden method
+--FILE--
+<?php
+class Foo
+{
+    #[TentativeReturnType]
+    public function x(): string|false
+    {
+        return "x";
+    }
+}
+
+class Bar extends Foo
+{
+    #[SuppressTentativeReturnTypeNotice]
+    public function x(): array
+    {
+        return [];
+    }
+}
+
+$bar = new Bar();
+var_dump($bar->x());
+?>
+--EXPECTF--
+array(0) {
+}

Zend/tests/type_declarations/variance/optional_return_type/suppressed_incompatible_return_type2.phpt

@@ -0,0 +1,28 @@
+--TEST--
+Test that the notice can be suppressed when the return type/value of the overriding method is incompatible with the tentative return type/value of the overridden method
+--FILE--
+<?php
+class Foo
+{
+    #[TentativeReturnType]
+    public function x(): string|false
+    {
+        return "x";
+    }
+}
+
+class Bar extends Foo
+{
+    #[SuppressTentativeReturnTypeNotice]
+    public function x()
+    {
+        return [];
+    }
+}
+
+$bar = new Bar();
+var_dump($bar->x());
+?>
+--EXPECTF--
+array(0) {
+}