ReflectionEnum::getCase() throws instead of returning false

Author: iluuu1994

ext/reflection/php_reflection.c

@@ -6596,8 +6596,13 @@ ZEND_METHOD(ReflectionEnum, getCase)
 	GET_REFLECTION_OBJECT_PTR(ce);
 
 	zend_class_constant *constant = zend_hash_find_ptr(&ce->constants_table, name);
-	if (constant == NULL || !(Z_ACCESS_FLAGS(constant->value) & ZEND_CLASS_CONST_IS_CASE)) {
-		RETURN_FALSE;
+	if (constant == NULL) {
+		zend_throw_exception_ex(reflection_exception_ptr, 0, "Case %s::%s does not exist", ZSTR_VAL(ce->name), ZSTR_VAL(name));
+		RETURN_THROWS();
+	}
+	if (!(Z_ACCESS_FLAGS(constant->value) & ZEND_CLASS_CONST_IS_CASE)) {
+		zend_throw_exception_ex(reflection_exception_ptr, 0, "%s::%s is not a case", ZSTR_VAL(ce->name), ZSTR_VAL(name));
+		RETURN_THROWS();
 	}
 
 	reflection_enum_case_factory(ce, name, constant, return_value);

ext/reflection/php_reflection.stub.php

@@ -694,7 +694,7 @@ public function __construct(object|string $objectOrClass) {}
 
     public function hasCase(string $name): bool {}
 
-    public function getCase(string $name): ReflectionEnumUnitCase|false {}
+    public function getCase(string $name): ReflectionEnumUnitCase {}
 
     /** @return ReflectionEnumUnitCase[] */
     public function getCases(): array {}

ext/reflection/php_reflection_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: b4ec9ccf1844750cdc959918192efb3d22b257ce */
+ * Stub hash: 3594ec0b0c3ed7266223be9c6b426aac56e3aabe */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Reflection_getModifierNames, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, modifiers, IS_LONG, 0)
@@ -499,7 +499,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_ReflectionEnum_hasCase, 0,
 	ZEND_ARG_TYPE_INFO(0, name, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
-ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_class_ReflectionEnum_getCase, 0, 1, ReflectionEnumUnitCase, MAY_BE_FALSE)
+ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_class_ReflectionEnum_getCase, 0, 1, ReflectionEnumUnitCase, 0)
 	ZEND_ARG_TYPE_INFO(0, name, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 

ext/reflection/tests/ReflectionEnum_getCase.phpt

@@ -13,15 +13,22 @@ enum IntEnum: int {
     const Bar = self::Foo;
 }
 
-$reflectionEnum = new ReflectionEnum(Enum_::class);
-var_dump($reflectionEnum->getCase('Foo'));
-var_dump($reflectionEnum->getCase('Bar'));
-var_dump($reflectionEnum->getCase('Baz'));
+function test(string $enumName, string $caseName) {
+    try {
+        $reflectionEnum = new ReflectionEnum($enumName);
+        var_dump($reflectionEnum->getCase($caseName));
+    } catch (Throwable $e) {
+        echo get_class($e) . ': ' . $e->getMessage() . "\n";
+    }
+}
+
+test(Enum_::class, 'Foo');
+test(Enum_::class, 'Bar');
+test(Enum_::class, 'Baz');
 
-$reflectionEnum = new ReflectionEnum(IntEnum::class);
-var_dump($reflectionEnum->getCase('Foo'));
-var_dump($reflectionEnum->getCase('Bar'));
-var_dump($reflectionEnum->getCase('Baz'));
+test(IntEnum::class, 'Foo');
+test(IntEnum::class, 'Bar');
+test(IntEnum::class, 'Baz');
 
 ?>
 --EXPECT--
@@ -31,13 +38,13 @@ object(ReflectionEnumUnitCase)#2 (2) {
   ["class"]=>
   string(5) "Enum_"
 }
-bool(false)
-bool(false)
-object(ReflectionEnumBackedCase)#1 (2) {
+ReflectionException: Enum_::Bar is not a case
+ReflectionException: Case Enum_::Baz does not exist
+object(ReflectionEnumBackedCase)#2 (2) {
   ["name"]=>
   string(3) "Foo"
   ["class"]=>
   string(7) "IntEnum"
 }
-bool(false)
-bool(false)
+ReflectionException: IntEnum::Bar is not a case
+ReflectionException: Case IntEnum::Baz does not exist