Merge branch 'PHP-7.3' into PHP-7.4

cmb69 · cmb69 · commit acce991a37e3 · 2020-10-12T13:32:40.000+02:00
* PHP-7.3:
  Fix #80220: imap_mail_compose() may leak memory
diff --git a/NEWS b/NEWS
@@ -16,6 +16,7 @@ PHP                                                                        NEWS
 - IMAP:
   . Fixed bug #80213 (imap_mail_compose() segfaults on certain $bodies). (cmb)
   . Fixed bug #80215 (imap_mail_compose() may modify by-val parameters). (cmb)
+  . Fixed bug #80220 (imap_mail_compose() may leak memory). (cmb)
 
 - MySQLnd:
   . Fixed bug #80115 (mysqlnd.debug doesn't recognize absolute paths with
diff --git a/ext/imap/php_imap.c b/ext/imap/php_imap.c
@@ -3726,7 +3726,7 @@ PHP_FUNCTION(imap_mail_compose)
 				convert_to_string_ex(pvalue);
 				bod->md5 = cpystr(Z_STRVAL_P(pvalue));
 			}
-		} else if (Z_TYPE_P(data) == IS_ARRAY) {
+		} else if (Z_TYPE_P(data) == IS_ARRAY && topbod->type == TYPEMULTIPART) {
 			short type = -1;
 			SEPARATE_ARRAY(data);
 			if ((pvalue = zend_hash_str_find(Z_ARRVAL_P(data), "type", sizeof("type") - 1)) != NULL) {

Original file line number	Diff line number	Diff line change
`@@ -3726,7 +3726,7 @@ PHP_FUNCTION(imap_mail_compose)`
`3726`	`3726`	`convert_to_string_ex(pvalue);`
`3727`	`3727`	`bod->md5 = cpystr(Z_STRVAL_P(pvalue));`
`3728`	`3728`	`}`
`3729`		`- } else if (Z_TYPE_P(data) == IS_ARRAY) {`
	`3729`	`+ } else if (Z_TYPE_P(data) == IS_ARRAY && topbod->type == TYPEMULTIPART) {`
`3730`	`3730`	`short type = -1;`
`3731`	`3731`	`SEPARATE_ARRAY(data);`
`3732`	`3732`	`if ((pvalue = zend_hash_str_find(Z_ARRVAL_P(data), "type", sizeof("type") - 1)) != NULL) {`