Missing declarations & sprintf -> slprintf (just in case)

jahyvari · jahyvari · commit 781a417f482e · 2022-02-09T10:46:49.000+02:00
diff --git a/ext/libxml/php_libxml2.def b/ext/libxml/php_libxml2.def
@@ -1547,3 +1547,5 @@ xmlXPtrWrapLocationSet
 xmlBufContent
 xmlBufUse
 xmlBufferDetach
+xmlOutputBufferGetContent
+xmlOutputBufferGetSize
diff --git a/ext/soap/config.w32 b/ext/soap/config.w32
@@ -13,10 +13,6 @@ if (PHP_SOAP != "no") {
 
 		if (!PHP_SOAP_SHARED) {
 			ADD_FLAG('CFLAGS_SOAP', "/D LIBXML_STATIC ");
-		} else {
-			if (!CHECK_LIB('libxml2.lib', 'soap')) {
-				WARNING("soap support can't be enabled, libxml is not found");
-			}
 		}
 	} else {
 			WARNING("soap not enabled, libxml not found");
diff --git a/ext/soap/php_wss.c b/ext/soap/php_wss.c
@@ -120,9 +120,9 @@ void add_wss_to_function_call(zval *this_ptr, int soap_version, xmlNodePtr envel
 {
 	char random_s[10];
 	if (Z_TYPE_P(Z_CLIENT_WSS_RANDOM_ID_P(this_ptr)) == IS_TRUE) {
-		sprintf(random_s, "%d", (int)php_mt_rand_common(100000000,999999999));
+		slprintf(random_s, sizeof(random_s), "%d", (int)php_mt_rand_common(100000000,999999999));
 	} else {
-		sprintf(random_s, "%d", 1);
+		slprintf(random_s, sizeof(random_s), "%d", 1);
 	}
 
 	zend_string *body_id = zend_string_concat2(

Original file line number	Diff line number	Diff line change
`@@ -120,9 +120,9 @@ void add_wss_to_function_call(zval *this_ptr, int soap_version, xmlNodePtr envel`
`120`	`120`	`{`
`121`	`121`	`char random_s[10];`
`122`	`122`	`if (Z_TYPE_P(Z_CLIENT_WSS_RANDOM_ID_P(this_ptr)) == IS_TRUE) {`
`123`		`- sprintf(random_s, "%d", (int)php_mt_rand_common(100000000,999999999));`
	`123`	`+ slprintf(random_s, sizeof(random_s), "%d", (int)php_mt_rand_common(100000000,999999999));`
`124`	`124`	`} else {`
`125`		`- sprintf(random_s, "%d", 1);`
	`125`	`+ slprintf(random_s, sizeof(random_s), "%d", 1);`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`zend_string *body_id = zend_string_concat2(`