Add FIXME

nielsdos · nielsdos · commit 564df33ac141 · 2025-05-29T10:02:43.000+02:00
diff --git a/ext/soap/php_xml.c b/ext/soap/php_xml.c
@@ -183,6 +183,7 @@ xmlDocPtr soap_xmlParseMemory(const void *buf, size_t buf_size)
 	return ret;
 }
 
+/* FIXME: this is wrong, attributes don't inherit the namespace of the node they're in! */
 xmlNsPtr attr_find_ns(xmlAttrPtr node)
 {
 	if (node->ns) {

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ xmlDocPtr soap_xmlParseMemory(const void *buf, size_t buf_size)`
`183`	`183`	`return ret;`
`184`	`184`	`}`
`185`	`185`
	`186`	`+/* FIXME: this is wrong, attributes don't inherit the namespace of the node they're in! */`
`186`	`187`	`xmlNsPtr attr_find_ns(xmlAttrPtr node)`
`187`	`188`	`{`
`188`	`189`	`if (node->ns) {`