Improve warning message

arnaud-lb · arnaud-lb · commit 28642827256a · 2022-10-07T15:48:05.000+02:00
diff --git a/ext/opcache/ZendAccelerator.c b/ext/opcache/ZendAccelerator.c
@@ -4677,7 +4677,7 @@ static int accel_finish_startup_preload_subprocess(pid_t *pid)
 	if (euid != 0) {
 		if (ZCG(accel_directives).preload_user
 		 && *ZCG(accel_directives).preload_user) {
-			zend_accel_error(ACCEL_LOG_WARNING, "\"opcache.preload_user\" is ignored");
+			zend_accel_error(ACCEL_LOG_WARNING, "\"opcache.preload_user\" is ignored because the current user is not \"root\"");
 		}
 
 		*pid = -1;
diff --git a/ext/opcache/tests/preload_user_001.phpt b/ext/opcache/tests/preload_user_001.phpt
@@ -22,7 +22,7 @@ var_dump(function_exists("f2"));
 ?>
 OK
 --EXPECTF--
-%sWarning "opcache.preload_user" is ignored
+%sWarning "opcache.preload_user" is ignored because the current user is not "root"
 bool(true)
 bool(false)
 OK

Original file line number	Diff line number	Diff line change
`@@ -4677,7 +4677,7 @@ static int accel_finish_startup_preload_subprocess(pid_t *pid)`
`4677`	`4677`	`if (euid != 0) {`
`4678`	`4678`	`if (ZCG(accel_directives).preload_user`
`4679`	`4679`	`&& *ZCG(accel_directives).preload_user) {`
`4680`		`- zend_accel_error(ACCEL_LOG_WARNING, "\"opcache.preload_user\" is ignored");`
	`4680`	`+ zend_accel_error(ACCEL_LOG_WARNING, "\"opcache.preload_user\" is ignored because the current user is not \"root\"");`
`4681`	`4681`	`}`
`4682`	`4682`
`4683`	`4683`	`*pid = -1;`