feat: Add PHP 8.4 support

Signed-off-by: Joas Schilling <[email protected]>

Author: nickvergessen

.github/workflows/unit_tests.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-         php: [ 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3 ]
+         php: [ 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3, 8.4 ]
          composer:
            - name: lowest
              arg: "--prefer-lowest --prefer-stable"

src/Common/Auth/AuthHandler.php

@@ -25,7 +25,7 @@ class AuthHandler
     /** @var Token */
     private $token;
 
-    public function __construct(callable $nextHandler, callable $tokenGenerator, Token $token = null)
+    public function __construct(callable $nextHandler, callable $tokenGenerator, ?Token $token = null)
     {
         $this->nextHandler    = $nextHandler;
         $this->tokenGenerator = $tokenGenerator;

src/Common/Error/Builder.php

@@ -35,7 +35,7 @@ class Builder
      */
     private $client;
 
-    public function __construct(ClientInterface $client = null)
+    public function __construct(?ClientInterface $client = null)
     {
         $this->client = $client ?: new Client();
     }
@@ -164,7 +164,7 @@ private function getStatusCodeMessage(int $statusCode): string
      * @param mixed       $userValue    The incorrect value the user actually provided
      * @param string|null $furtherLink  a link to further information if necessary (optional)
      */
-    public function userInputError(string $expectedType, $userValue, string $furtherLink = null): UserInputError
+    public function userInputError(string $expectedType, $userValue, ?string $furtherLink = null): UserInputError
     {
         $message = $this->header('User Input Error');
 

src/Common/HydratorStrategyTrait.php

@@ -25,7 +25,7 @@ public function hydrate(array $data, array $aliases = [])
         }
     }
 
-    public function set(string $key, $property, array $data, callable $fn = null)
+    public function set(string $key, $property, array $data, ?callable $fn = null)
     {
         if (isset($data[$key]) && property_exists($this, $property)) {
             $value           = $fn ? call_user_func($fn, $data[$key]) : $data[$key];

src/Common/JsonSchema/Schema.php

@@ -14,7 +14,7 @@ class Schema
     /** @var Validator */
     private $validator;
 
-    public function __construct($body, Validator $validator = null)
+    public function __construct($body, ?Validator $validator = null)
     {
         $this->body      = (object) $body;
         $this->validator = $validator ?: new Validator();

src/Common/Resource/Alias.php

@@ -26,7 +26,7 @@ class Alias
      * @param string|null $className    A class name for the property value
      * @param bool        $list         Whether value of the property should be treated as a list or not
      */
-    public function __construct(string $propertyName, string $className = null, bool $list = false)
+    public function __construct(string $propertyName, ?string $className = null, bool $list = false)
     {
         $this->isList       = $list;
         $this->propertyName = $propertyName;

src/Common/Resource/Listable.php

@@ -18,11 +18,11 @@ interface Listable
      * of the marker will depend on the last element returned in the previous response. If a limit is
      * provided, the loop will continue up until that point.
      *
-     * @param array    $def      The operation definition
-     * @param array    $userVals The user values
-     * @param callable $mapFn    an optional callback that will be executed on every resource iteration
+     * @param array         $def      The operation definition
+     * @param array         $userVals The user values
+     * @param callable|null $mapFn    an optional callback that will be executed on every resource iteration
      *
      * @returns \Generator<mixed, static>
      */
-    public function enumerate(array $def, array $userVals = [], callable $mapFn = null);
+    public function enumerate(array $def, array $userVals = [], ?callable $mapFn = null);
 }

src/Common/Resource/OperatorResource.php

@@ -69,7 +69,7 @@ private function getResourcesKey(): string
      *
      * @returns \Generator<mixed, static>
      */
-    public function enumerate(array $def, array $userVals = [], callable $mapFn = null): \Generator
+    public function enumerate(array $def, array $userVals = [], ?callable $mapFn = null): \Generator
     {
         $operation = $this->getOperation($def);
 
@@ -105,7 +105,7 @@ public function enumerate(array $def, array $userVals = [], callable $mapFn = nu
      *
      * @return array<self>
      */
-    public function extractMultipleInstances(ResponseInterface $response, string $key = null): array
+    public function extractMultipleInstances(ResponseInterface $response, ?string $key = null): array
     {
         $key           = $key ?: $this->getResourcesKey();
         $resourcesData = Utils::jsonDecode($response)[$key];

src/Common/Service/Builder.php

@@ -109,7 +109,7 @@ private function stockAuthHandler(array &$options): void
         }
     }
 
-    private function httpClient(string $baseUrl, HandlerStack $stack, string $serviceType = null, string $microVersion = null): ClientInterface
+    private function httpClient(string $baseUrl, HandlerStack $stack, ?string $serviceType = null, ?string $microVersion = null): ClientInterface
     {
         $clientOptions = [
             'base_uri' => Utils::normalizeUrl($baseUrl),

src/Common/Transport/HandlerStack.php

@@ -10,7 +10,7 @@ class HandlerStack
     /**
      * @deprecated use \OpenStack\Common\Transport\HandlerStackFactory::createWithOptions instead
      */
-    public static function create(callable $handler = null): \GuzzleHttp\HandlerStack
+    public static function create(?callable $handler = null): \GuzzleHttp\HandlerStack
     {
         return HandlerStackFactory::create($handler);
     }